Switch remaining uses of vscode.window.show*Message to the HostBridge #5324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abeatrix
approved these changes
Aug 3, 2025
Switch over the remaining uses. Turn on the linter check to prevent these APIs being reintroduced later. Exclude test files from the linter check.
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-03T23:52:36.067798 |
abeatrix
approved these changes
Aug 4, 2025
dtrugman
pushed a commit
to dtrugman/cline
that referenced
this pull request
Aug 24, 2025
…ine#5324) (cline#5849) * feat: add Issue Fixer Orchestrator mode * fix: allow export task history while API is active (cline#5324) - Add exportAlwaysEnabled prop to TaskActions component - Export button remains enabled when exportAlwaysEnabled is true - Other action buttons still respect buttonsDisabled state - Add tests to verify the new behavior This fixes the regression where users couldn't export task history during API operations, which is a common debugging workflow. * fix: simplify export button to always be enabled The export functionality is not impacted by the model streaming state, so the button should always be enabled. Removed the unnecessary exportAlwaysEnabled prop and simplified the implementation. - Remove exportAlwaysEnabled prop from TaskActions - Remove disabled attribute from export button entirely - Update TaskHeader to remove exportAlwaysEnabled prop usage - Update tests to reflect that export is always enabled * fix: enable export, share, and copy buttons during API operations - Export, share, and copy buttons now remain enabled when API is active - Delete button still respects buttonsDisabled state for safety - Removed unnecessary exportAlwaysEnabled prop - Updated tests to reflect new behavior --------- Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch over the remaining uses of vscode.window.show*Message APIs to use the HostBridge.
Turn on the linter check to prevent these APIs being reintroduced later.
Turn on linter check for
vscode.window.showInputBox.Exclude test files from the linter check.
Important
Switch remaining
vscode.window.show*Messagecalls toHostBridgeand enforce via linter, excluding test files.vscode.window.show*MessagewithHostProvider.window.showMessageindetect-omission.ts,TelemetryService.ts, andgithub-url-utils.ts.vscode.window.show*Messageandvscode.window.showInputBoxinno-direct-vscode-api.js.no-direct-vscode-api.js.no-direct-vscode-api.test.tsto reflect new linter rules, allowingvscode.postMessagein test files.vscode.window.showInputBoxinno-direct-vscode-api.js.no-direct-vscode-api.js.This description was created by
for 3e2dd0c. You can customize this summary. It will automatically update as commits are pushed.