Add getCallbackUri to the HostProvider
#5322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-03T23:53:40.460067 |
**Centralize callback URI management** through the HostProvider instead of having it in multiple places in the codebase. **Simplify error handling** by making the callback URI required rather than optional The changes are related to **authentication callback URI handling** in the Cline extension. Here's what's being modified: - Simplified callback URI retrieval - Changed return type from `Promise<string | undefined>` to `Promise<string>` - Now throws an error if AuthHandler is not enabled instead of returning undefined - Added a new `getCallbackUri` property that returns a `Promise<string>` - This allows the host provider to supply callback URIs for authentication - Implemented callback URI provider - Updated to use HostProvider for callback URI - Updated to match new signature
getCallUri to the HostProvidergetCallbackUri to the HostProvider
abeatrix
added a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize callback URI management through the HostProvider instead of having it in multiple places in the codebase. This moves the dependency on the
vscode.env.uriSchemeinto the vscode specific code.1. AuthHandler.ts
2. HostProvider.ts - Added callback URI provider
getCallbackUriproperty that returns aPromise<string>3. extension.ts
uriScheme4. cline-core.ts
AuthHandler5. AuthService.ts
Test Procedure
Tested manually in the vscode extension host and with cline-core standalone service.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Additional Notes
Important
Centralized callback URI management by adding
getCallbackUritoHostProvider, updatingAuthHandler,AuthService,extension.ts, andcline-core.tsto use it.getCallbackUritoHostProviderto centralize callback URI management.getCallbackUrireturns aPromise<string>for authentication callback URIs.AuthHandleris not enabled.HostProvider.getCallbackUri()for callback URIs.vscode.env.uriScheme.AuthHandler.This description was created by
for aff145d. You can customize this summary. It will automatically update as commits are pushed.