Remove things that were left over from the ProtoBus migration. #5321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's only two types of WebMessage: `grpc_request` and `grpc_cancel`. Remove the others from the WebMessage. In the handleWebMessage case statement, remove the type "fetchMcpMarketplace", it in use anymore. Log an invalid messages that are received. Make the `GrpcRequest` and `GrpcResponse` into types so they can be used elsewhere in the codebase.
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-03T23:52:12.108271 |
canvrno
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified WebMessage Types (
src/shared/WebviewMessage.ts):grpc_requestandgrpc_request_cancelGrpcRequestandGrpcCancelinto separate type definitions for reusabilityCleaned Up Message Handling (
src/core/controller/index.ts):fetchMcpMarketplacecase from the message handlerfetchMcpMarketplaceprivate method which is now dead code.Improved Type Definitions (
src/shared/ExtensionMessage.ts):GrpcResponseas a separate type definition (previously inline)Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Additional Notes