Refactoring: move postMessageToWebview into vscode specific code
#5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the code for handling the webview protobus messages out of the controller and into the VscodeWebviewProvider because it is only applicable to vscode. The standalone app uses the src/standalone/protobus-service.ts to handle ProtoBus requests. Remove vscode stubs for postMessage. Remove unused code from the `TestServer`. Update comments that refer to `postMessageToWebview`.
|
postMessageToWebview into vscode specific code.postMessageToWebview into vscode specific code
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-06T15:09:23.707663 |
dtrugman
pushed a commit
to dtrugman/cline
that referenced
this pull request
Aug 24, 2025
Co-authored-by: matt <matt@roocode.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code for handling the webview protobus messages out of the
Controllerand into the
VscodeWebviewProviderbecause it is only used on vscode. (The standalone app uses thesrc/standalone/protobus-service.tsto handle ProtoBus requests.)The aim is to remove dependencies on the vscode SDK from the
src/coreand make it clearerfrom the layout of the codebase what is being used on each platform.
Remove vscode stubs for postMessage from
src/standalone.Remove unused code from the
TestServer.Update comments that refer to
postMessageToWebview.