Hostbridge diff diagnostics #5368
Merged
+270
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s functionality from direct VS Code API calls to the hostbridge layer to enable multi-host support (VS Code + IntelliJ).
|
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-06T01:19:52.490231 |
sjf
reviewed
Aug 5, 2025
sjf
reviewed
Aug 6, 2025
sjf
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the diff edit diagnostics functionality from direct VS Code API calls to hostbridge.
Changes:
getDiagnosticsRPC toDiffServiceinproto/host/diff.protosrc/hosts/vscode/hostbridge/diff/getDiagnostics.tsVscodeDiffViewProviderto usegetAllDiagnostics()via hostbridge instead of directvscode.languages.getDiagnostics()@problemsmention functionality to use hostbridge abstractionThe diagnostics functionality now flows through:
Client → HostProvider.diff.getDiagnostics() → gRPC → VS Code Implementation → Response, enabling other platforms to implement the same interface.Test Procedure
@problemsin chat triggers hostbridge call and displays workspace diagnostics correctlyVerified hostbridge flow: Console logs showed complete gRPC request/response cycle with proper diagnostic data transformation between proto and VS Code formats. Both functionalities work identically to before, but now use hostbridge instead of direct VS Code APIs.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Important
Refactor diagnostics functionality to use hostbridge for cross-platform compatibility, adding a new RPC and updating related classes and functions.
getDiagnosticsRPC toDiffServiceinproto/host/workspace.proto.src/hosts/vscode/hostbridge/workspace/getDiagnostics.ts.VscodeDiffViewProviderandExternalDiffViewProviderto usegetDiagnostics()via hostbridge.@problemsmention functionality to use hostbridge abstraction.getNewDiagnostics()anddiagnosticsToProblemsString()insrc/hosts/vscode/diagnostics.ts.getWorkspaceProblemsString()insrc/integrations/diagnostics/index.tsfor cross-host compatibility.This description was created by
for 5271789. You can customize this summary. It will automatically update as commits are pushed.