Skip to content

Revert "Add getCallUri to the HostProvider (#5322)" #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Revert "Add getCallUri to the HostProvider (#5322)" #5359

merged 1 commit into from
Aug 4, 2025

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Aug 4, 2025 •
edited by ellipsis-dev bot
Loading

Related Issue

Issue: #XXXX

Description

This reverts commit b8227c1.

Test Procedure

Green CI

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Revert addition of getCallbackUri to HostProvider, adjusting related logic and tests.

  • Revert Changes:
    • Remove getCallbackUri from HostProvider in host-provider.ts.
    • Remove getCallbackUri logic from AuthHandler in AuthHandler.ts.
    • Adjust AuthService in AuthService.ts to use AuthHandler.getInstance().getCallbackUri() directly.
  • Tests:
    • Update FileContextTracker.test.ts and cline-api.test.ts to remove getCallbackUri references.
  • Misc:
    • Remove getCallbackUri initialization in extension.ts and cline-core.ts.

This description was created by Ellipsis for 98dc056. You can customize this summary. It will automatically update as commits are pushed.

@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 23:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: 98dc056

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot
Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts commit b8227c1 which previously added getCallUri functionality to the HostProvider. The revert removes the callback URI provider pattern from the HostProvider and moves the authentication callback handling back to the AuthService directly.

  • Removes getCallbackUri parameter from HostProvider initialization
  • Restores direct AuthHandler usage in AuthService for callback URI generation
  • Updates AuthHandler to return undefined instead of throwing when disabled
  • Moves AuthHandler initialization after service setup in cline-core

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/hosts/host-provider.ts Removes getCallbackUri parameter and property from HostProvider class
src/extension.ts Removes getCallbackUri function from HostProvider initialization
src/standalone/cline-core.ts Removes getCallbackUri from HostProvider setup and moves AuthHandler enablement
src/services/auth/AuthService.ts Reverts to direct AuthHandler usage instead of HostProvider for callback URI
src/hosts/external/AuthHandler.ts Changes getCallbackUri to return undefined when disabled instead of throwing
src/test/cline-api.test.ts Removes getCallbackUri parameter from test HostProvider initialization
src/core/context/context-tracking/FileContextTracker.test.ts Removes getCallbackUri parameter from test HostProvider initialization

@abeatrix abeatrix requested review from sjf and removed request for Garoth, dcbartlett, ocasta181, saoudrizwan, saito-sv, pashpashpash and NightTrek August 4, 2025 23:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

Last updated: 2025-08-04T23:27:55.926501

@abeatrix abeatrix merged commit 67bab94 into main Aug 4, 2025
13 checks passed
@abeatrix abeatrix deleted the bee/revert-b8227c1 branch August 4, 2025 23:30
dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
@liwilliam2021
Make the prompts editable now (cline#5359)
a9a87c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@sjf sjf sjf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeatrix @sjf