Simplify the GrpcHandler and add tests #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use two functions handleUnaryRequest and handleStreamingRequest, instead of creating a GrpcHandler object and calling class methods on it. * Remove redundant try/catch and empty finally blocks. Each of the two handler functions has it's own try/catch. * Each of the two functions is responsible for posting the result to the webview- Instead of unary and streaming responses being handled at different levels. * Use the GrpcRequest and GrpcCancel types.
|
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-04T23:03:18.516717 |
tseglevskiy
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the GrpcHandler and add tests before adding support for JSON encoding for external clients.
Important
Simplify
GrpcHandlerby replacing it with functions and add comprehensive tests for request handling.GrpcHandlerclass withhandleUnaryRequestandhandleStreamingRequestfunctions ingrpc-handler.ts.GrpcRequestandGrpcCanceltypes for request handling.handleUnaryRequestandhandleStreamingRequestpost results directly to the webview.grpc-handler.test.tsfor unary and streaming requests, error scenarios, and request cancellation.This description was created by
for 515eec3. You can customize this summary. It will automatically update as commits are pushed.