Skip to content

Add logging to the webview ProtoBus client #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Add logging to the webview ProtoBus client #5353

merged 1 commit into from
Aug 4, 2025

Conversation

sjf
Copy link
Contributor

@sjf sjf commented Aug 4, 2025

Add error logging to the grpc client in the webview, if it receives a ProtoBus message that is missing required fields.

Important

Adds logging to ProtoBusClient for malformed ProtoBus messages with no response or error.

  • Logging:
    • Adds console.error logging in makeRequest and makeStreamingRequest methods of ProtoBusClient for messages with no response or error.
  • Behavior:
    • Logs malformed ProtoBus messages to console for better debugging.

This description was created by Ellipsis for 0a5658b. You can customize this summary. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: 0a5658b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sjf sjf changed the title Add logging to the webview ProtoBus client if it recieves a badly formed message Add logging to the webview ProtoBus client Aug 4, 2025
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

⚠️ Warning: Coverage decreased by 0.01%

Consider adding tests to cover your changes.

Overall Assessment

⚠️ Test coverage has decreased in this PR

Please consider adding tests to maintain or improve coverage.

Last updated: 2025-08-04T21:13:51.625357

@sjf sjf merged commit 8fee09f into main Aug 4, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants