Skip to content

fix: flaky check for editor search bar #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2025
Merged

fix: flaky check for editor search bar #5347

merged 2 commits into from
Aug 4, 2025

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Aug 4, 2025 •
edited by ellipsis-dev bot
Loading

Related Issue

Issue: #XXXX

Description

Remove the visible check during e2e test set up as that one is flaky and cause the tests fail unnecessarily.

Test Procedure

CI should be green

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Removes flaky visibility check in runCommandPalette() and adjusts click delays in helpers.ts to improve test reliability.

  • Behavior:
    • Removes flaky visibility check for editorSearchBar in runCommandPalette() in helpers.ts.
    • Adjusts click delay for editorMenu and editorSearchBar to 100ms to ensure focus.
  • Misc:
    • Removes command to toggle notifications in e2e test setup in helpers.ts.

This description was created by Ellipsis for 7e8c784. You can customize this summary. It will automatically update as commits are pushed.

@Copilot Copilot AI review requested due to automatic review settings August 4, 2025 18:29
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7e8c784

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot
Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky e2e test by removing a visibility check for the editor search bar that was causing unnecessary test failures.

  • Removes the flaky toBeVisible() assertion for the editor search bar
  • Adds a small delay to the editor menu click for better reliability

arafatkatze
arafatkatze approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@arafatkatze arafatkatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025 •
edited
Loading

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

⚠️ Warning: Coverage decreased by 0.19%

Consider adding tests to cover your changes.

Overall Assessment

⚠️ Test coverage has decreased in this PR

Please consider adding tests to maintain or improve coverage.

Last updated: 2025-08-04T18:48:46.481644

@arafatkatze arafatkatze merged commit e2045bf into main Aug 4, 2025
13 checks passed
@abeatrix abeatrix deleted the bee/e2e-editor-search branch August 4, 2025 19:39
dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
@mrubens
Add .vscode/ to the list of write-protected files/directories (cline#…
3993406 
…5347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@arafatkatze arafatkatze arafatkatze approved these changes

@saoudrizwan saoudrizwan Awaiting requested review from saoudrizwan

@ocasta181 ocasta181 Awaiting requested review from ocasta181

@NightTrek NightTrek Awaiting requested review from NightTrek

@pashpashpash pashpashpash Awaiting requested review from pashpashpash

@dcbartlett dcbartlett Awaiting requested review from dcbartlett

@saito-sv saito-sv Awaiting requested review from saito-sv

@Garoth Garoth Awaiting requested review from Garoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeatrix @arafatkatze