Update saveOpenDocumentIfDirty to return if the doc was saved or not #5343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return wasSaved: true only when a dirty document is actually saved - Add integration tests for the RPC
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-04T14:31:11.686415 |
celestial-vault
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasSaved: true only when the document was actually savedsaveOpenDocumentIfDirtyImportant
Update
saveOpenDocumentIfDirtyto return save status and add integration tests for various scenarios.saveOpenDocumentIfDirtynow returnsSaveOpenDocumentIfDirtyResponsewithwasSavedindicating if a document was saved.saveOpenDocumentIfDirty.test.tsfor integration tests.saveOpenDocumentIfDirtyRPC inworkspace.prototo returnSaveOpenDocumentIfDirtyResponse.This description was created by
for 039e189. You can customize this summary. It will automatically update as commits are pushed.