fix issue where cline is occasionally bricked by the diffViewProvider attempting to close tabs #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage ReportExtension CoverageBase branch: 46% PR branch: 47% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-29T03:02:02.000199 |
arafatkatze
approved these changes
Jul 29, 2025
dtrugman
pushed a commit
to dtrugman/cline
that referenced
this pull request
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Issue: #XXXX
Description
There is no try-catch on the diffViewEditor logic for closing dirty tabs which occasionally throws an error and bricks cline entirely. The underlying issue is that there's no error handling on the attempt to close the tabs. It may be worth in the future adding logic to re-try on initial failure
Test Procedure
To reproduce this have the same file opened on lhs and rhs and have cline try to edit the file. This will (often) throw an error which results in bricking cline.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
recording:
record.bricking.mov
screenshot:
Additional Notes
Important
Add error handling for tab closing in
VscodeDiffViewProviderto prevent application crashes.vscode.window.tabGroups.close(tab)inVscodeDiffViewProviderto handle errors when closing tabs.openDiffEditor()andcloseDiffView()methods inVscodeDiffViewProviderare updated with error handling for tab closing.This description was created by
for b0522ad. You can customize this summary. It will automatically update as commits are pushed.