fix: clear streamingFailedMessage when user manually retries #5222
Conversation
- Clear streamingFailedMessage when user manually retries - Convert imports to type-only where appropriate - Reorder imports for better organization - Add explicit type annotations for better type safety - Move node:timers/promises import to top
🦋 Changeset detectedLatest commit: e8b5cc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where streaming failure messages were not being cleared when a user manually retries a task, while also performing code organization improvements.
- Clear streamingFailedMessage when user manually retries to improve UX
- Convert imports to type-only where appropriate for better TypeScript performance
- Add explicit type annotations and reorganize imports for better code maintainability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/task/index.ts | Main fix to clear streaming errors on retry, plus import reorganization and type safety improvements |
| .changeset/clean-sheep-breathe.md | Changelog entry documenting the user-facing bug fix |
Comments suppressed due to low confidence (2)
src/core/task/index.ts:453
- [nitpick] Adding braces around this case is inconsistent with the "workspace" case below. Either add braces to all cases or remove them from this one for consistency.
case "taskAndWorkspace": {
src/core/task/index.ts:2343
- [nitpick] Adding braces around this case creates inconsistency with other cases in the same switch statement that don't use braces.
case "text": {
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-08-04T22:54:42.448570 |
|
Code looks alright, I have not tested this yet though. I'd like to test this again once #5158 is merged. Let's hold off on merging this until that's in. |
Related Issue
Issue: #XXXX
Description
Test Procedure
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
After
Screen.Recording.2025-08-04.at.3.36.11.PM.mov
Before
Screen.Recording.2025-08-04.at.3.42.43.PM.mov
Additional Notes
Important
Clear
streamingFailedMessagewhen user manually retries a task and improve code quality inindex.ts.streamingFailedMessageinattemptApiRequest()inindex.tswhen user manually retries a task.index.ts.index.tsfor better organization.index.tsfor better type safety.This description was created by
for e8b5cc0. You can customize this summary. It will automatically update as commits are pushed.