Change timeout, token budget and line limit fields in the ProtoBus from int64 to int32. #5221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…t32. As described [here](#5174), int64 cannot be deserialized directly into numbers in Typescript. Switch these timeout and line limit fields to int32 because the range of values should fit in int32. Replace the Int64Request and response in the RPC `updateTerminalConnectionTimeout` with request and response messages for this RPC. It is the best practise to have unique request/response messages for each RPC because it means you can update the request or response easily because the messages are not shared with other RPCs. The fields can also have self-documenting names instead of the generic `value` field name.
a3b6153 to
950beab
Compare
Coverage ReportExtension CoverageBase branch: 46% PR branch: 47% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-28T21:21:38.685848 |
canvrno
reviewed
Jul 28, 2025
canvrno
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here, int64 cannot be deserialized directly into numbers in Typescript.
Switch these timeout, token budgets and line limit fields to int32 because the range of values should fit in int32.
Replace the Int64Request and response in the RPC
updateTerminalConnectionTimeoutwith request and response messages for this RPC. It is the best practise to have unique request/response messages for each RPC because 1) it means you can update the request or response easily because the message is not shared with other RPCs; and 2) the fields can also have self-documenting names instead of the genericvaluefield name.Important
Change several ProtoBus fields from
int64toint32and updateupdateTerminalConnectionTimeoutRPC to use specific request/response messages.shell_integration_timeout,terminal_output_line_limit,fireworks_model_max_completion_tokens,fireworks_model_max_tokens,request_timeout_ms,plan_mode_thinking_budget_tokens, andact_mode_thinking_budget_tokensfromint64toint32instate.proto.Int64RequestandInt64withUpdateTerminalConnectionTimeoutRequestandUpdateTerminalConnectionTimeoutResponseforupdateTerminalConnectionTimeoutRPC instate.proto.updateTerminalConnectionTimeout()inupdateTerminalConnectionTimeout.tsto useUpdateTerminalConnectionTimeoutRequestandUpdateTerminalConnectionTimeoutResponse.TerminalSettingsSection.tsxto handleUpdateTerminalConnectionTimeoutResponseand update timeout handling logic.This description was created by
for cf61c14. You can customize this summary. It will automatically update as commits are pushed.