Skip to content

fix: E2E test stability by reordering sidebar and notification setup #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

fix: E2E test stability by reordering sidebar and notification setup #5279

merged 2 commits into from
Aug 1, 2025

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Jul 31, 2025 •
edited by ellipsis-dev bot
Loading

Related Issue

Issue: #XXXX

Description

  • Extract editor menu locator to variable for better readability
  • Move sidebar opening to page fixture to ensure it's available earlier
  • Wait for chat input visibility before disabling notifications
  • Prevents race conditions in test initialization

Test Procedure

Green CI

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Improves E2E test stability by reordering sidebar and notification setup in helpers.ts.

  • Behavior:
    • Extracts editor menu locator to a variable in runCommandPalette() for clarity.
    • Moves sidebar opening to page fixture in helpers.ts to ensure availability before use.
    • Disables notifications before opening sidebar to prevent race conditions.
  • Misc:
    • Minor refactor in helpers.ts to improve test stability.

This description was created by Ellipsis for 83ea633. You can customize this summary. It will automatically update as commits are pushed.

@abeatrix
fix: E2E test stability by reordering sidebar and notification setup
2918942 
- Extract editor menu locator to variable for better readability
- Move sidebar opening to page fixture to ensure it's available earlier
- Wait for chat input visibility before disabling notifications
- Prevents race conditions in test initialization
@Copilot Copilot AI review requested due to automatic review settings July 31, 2025 23:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 83ea633

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot
Copilot AI reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves E2E test stability by reordering the initialization sequence to prevent race conditions between sidebar setup and notification disabling.

  • Extract editor menu locator to a variable for better code readability
  • Move sidebar opening from sidebar fixture to page fixture for earlier availability
  • Add explicit wait for chat input visibility before disabling notifications

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

Last updated: 2025-07-31T23:29:23.576385

@arafatkatze
Copy link
Contributor

Since the E2E tests are passing I believe this works

@arafatkatze arafatkatze merged commit 3fc91e2 into main Aug 1, 2025
13 checks passed
dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
@SannidhyaSah
fix: move context condensing prompt to Prompts section (cline#4924) (c…
de13d8a 
…line#5279)

* feat: move context condensing prompt from context to prompts page

* fix: remove unused imports after lint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@arafatkatze arafatkatze arafatkatze approved these changes

@saoudrizwan saoudrizwan Awaiting requested review from saoudrizwan

@ocasta181 ocasta181 Awaiting requested review from ocasta181

@NightTrek NightTrek Awaiting requested review from NightTrek

@pashpashpash pashpashpash Awaiting requested review from pashpashpash

@dcbartlett dcbartlett Awaiting requested review from dcbartlett

@saito-sv saito-sv Awaiting requested review from saito-sv

@Garoth Garoth Awaiting requested review from Garoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeatrix @arafatkatze