fix grok browser_user issue due to not being able to process webp images #5278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-31T23:06:18.348902 |
abeatrix
approved these changes
Aug 1, 2025
dtrugman
pushed a commit
to dtrugman/cline
that referenced
this pull request
Aug 24, 2025
…cline#5278) * Enhance provider selection with search functionality * fix: add SearchableSelect mock to SettingsView.spec.tsx - Added SearchableSelect to the @/components/ui mock in SettingsView.spec.tsx - This resolves test failures after the SearchableSelect component was introduced - All 497 tests now pass successfully * test: add comprehensive tests for SearchableSelect component * feat: address PR feedback * fix: internationalize SearchableSelect placeholder in test mock - Replace hardcoded 'Select...' with i18n key 'settings:common.select' - Ensures consistency with actual component usage - Addresses PR review feedback --------- Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Issue: #XXXX
Description
The browser use tool does not work for Grok models due to our default for using webp formatted images, and Grok not supporting these. Originally we would get this error when sending the browser screen shots to Grok when using their provider:
400 "Invalid request content: Downloaded response does not contain a valid JPG or PNG image.". Fixed this by using png format for Grok modelsTest Procedure
Tested browser use tool for grok-4, sonnet-4, and gemini-2.5-pro to check that browser use still works for all. Also tested with and without using the remote browser connection.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Using grok-4 in browser use:
grok.single.click.mov
Additional Notes
Important
Enhance
ToolExecutorandBrowserSessionto handle webp image support based on model capabilities, addingmodelDoesntSupportWebp()function.ToolExecutornow includesGrok4model family inisNextGenModelchecks inpushToolResult()andhandleStreamingJsonReplacement().BrowserSessionconstructor now acceptsuseWebpparameter to determine screenshot format.BrowserSessionusesmodelDoesntSupportWebp()to decide betweenwebpandpngfor screenshots.modelDoesntSupportWebp()inmodel-utils.tsto check if a model supports webp images.doAction()andnavigateTourl("")inBrowserSessionto retry withpngifwebpfails.This description was created by
for be364d9. You can customize this summary. It will automatically update as commits are pushed.