Skip to content

Clean up getStateToPostToWebview #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Clean up getStateToPostToWebview #5266

merged 1 commit into from
Jul 31, 2025

Conversation

celestial-vault
Copy link
Contributor

@celestial-vault celestial-vault commented Jul 31, 2025 •
edited
Loading

Description

Just cleaning up the state a little bit to prepare for the migration to the CacheService.

Test Procedure

No major code changes.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Refactor getStateToPostToWebview in Controller to use getLatestAnnouncementId and optimize state retrieval in state.ts.

  • Refactoring:
    • Extracts getLatestAnnouncementId() to extension.ts and uses it in index.ts and onDidShowAnnouncement.ts.
    • Refactors getStateToPostToWebview() in index.ts to use getLatestAnnouncementId().
  • State Management:
    • Optimizes retrieval of local rules toggles in getAllExtensionState() in state.ts using Promise.all.
  • Misc:
    • Removes latestAnnouncementId getter from Controller class in index.ts.

This description was created by Ellipsis for eb9f3cf. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: eb9f3cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ellipsis-dev[bot]
ellipsis-dev bot reviewed Jul 31, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Extension Coverage

Base branch: 47%

PR branch: 48%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

Last updated: 2025-07-31T01:12:07.239547

abeatrix
abeatrix approved these changes Jul 31, 2025
View reviewed changes
@celestial-vault celestial-vault merged commit 8e984f2 into main Jul 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@abeatrix abeatrix abeatrix approved these changes

@saoudrizwan saoudrizwan Awaiting requested review from saoudrizwan

@ocasta181 ocasta181 Awaiting requested review from ocasta181

@NightTrek NightTrek Awaiting requested review from NightTrek

@pashpashpash pashpashpash Awaiting requested review from pashpashpash

@dcbartlett dcbartlett Awaiting requested review from dcbartlett

@saito-sv saito-sv Awaiting requested review from saito-sv

@Garoth Garoth Awaiting requested review from Garoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celestial-vault @abeatrix