Add vscode.workspace.findFiles to no-direct-vscode-api eslint rule.
#5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `vscode.workspace.findFiles` to the list of the Vscode API calls that should not be re-introduced to the extension unintentionally.
|
no-direct-vscode-api eslint rule.
canvrno
approved these changes
Jul 30, 2025
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-30T23:48:51.558742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
vscode.workspace.findFilesto the list of the Vscode API calls that should not be re-introduced to the extension unintentionally.Important
Add
vscode.workspace.findFilesto disallowed APIs inno-direct-vscode-api.jsESLint rule, promoting native JavaScript alternatives.vscode.workspace.findFilestodisallowedApisinno-direct-vscode-api.js.useNativemessage forvscode.workspace.findFilesto encourage using native JavaScript APIs.This description was created by
for 00d02ee. You can customize this summary. It will automatically update as commits are pushed.