test: update Playwright test timeouts #5241
Conversation
- Rename isGitHubAction to isCI for broader CI detection - Adjust timeout logic to use CI or Windows conditions - Reduce expect timeout from 40s/20s to 5s/2s for faster feedback - Decrease streaming chunk delay from 50ms to 20ms in server mock
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates Playwright test configurations to improve CI test performance and reliability by adjusting timeouts and streaming delays.
- Renamed
isGitHubActiontoisCIfor broader CI environment detection - Reduced expect timeouts from 40s/20s to 5s/2s for faster test feedback
- Decreased streaming chunk delay from 50ms to 20ms in server mock for improved performance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| playwright.config.ts | Updated timeout logic and renamed CI detection variable for broader compatibility |
| src/test/e2e/fixtures/server/index.ts | Reduced streaming chunk delay to improve test performance |
Comments suppressed due to low confidence (1)
playwright.config.ts:4
- The variable name 'isWindow' is ambiguous. It should be 'isWindows' to clearly indicate it's checking for the Windows platform.
const isWindow = process?.platform?.startsWith("win")
Coverage ReportExtension CoverageBase branch: 47% PR branch: 48% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-29T22:25:03.161240 |
|
PR makes trivial timeout changes and does what it claims to do. |
Related Issue
Issue: #XXXX
Description
Address some timeout issues noticed in CI
Test Procedure
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Additional Notes
Important
Update Playwright test timeouts and server mock delay for improved CI performance.
isGitHubActiontoisCIfor broader CI detection.timeoutto 40000ms for CI or Windows, 20000ms otherwise.expect.timeoutto 5000ms for CI or Windows, 2000ms otherwise.isCIfor reporter configuration.ClineApiServerMock.This description was created by
for d23f0b0. You can customize this summary. It will automatically update as commits are pushed.