Move the OutputChannel to the HostProvider #5189
Conversation
|
@sjf Do we even want this anymore? No one uses it. |
|
The extension is still using it, even though it doesn't seem super important. Really I am trying to remove it because it's pulling VS code dependencies into the HostProver and it's preventing me from making unit tests. |
|
Coverage ReportExtension CoverageBase branch: 46% PR branch: 47% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-28T19:03:47.150520 |
Replace `OutputChannel.appendLine` with `HostProvider.logToChannel`. Remove places where the cline OutputChannel was being passed around. Now it is stored in the HostProvider, so we don't need to do this. # Conflicts: # src/hosts/vscode/VscodeWebviewProvider.ts
…tputs the timestamp
Replace the vscode
OutputChannel.appendLinewithHostProvider.logToChannel.Remove places where the cline OutputChannel was being passed around. Now it is stored in the HostProvider, so we don't need to do this. We don't need to initialize the
Loggerto setup the output channel anymore, the channel is set up when the HostProvider is initialized.Remove the OutputChannel from the vscode-impls.
Important
Refactor logging by moving
OutputChannelmanagement toHostProvider, simplifying code and centralizing logging functionality.vscode.OutputChannel.appendLinewithHostProvider.logToChannelfor logging.OutputChannelparameter fromControllerandWebviewProviderconstructors.OutputChannelinHostProviderduring setup inextension.tsandcline-core.ts.Loggerclass to useHostProvider.logToChannelfor logging.cleanupLegacyCheckpoints()inCheckpointMigration.tsto useHostProvider.logToChannel.cline-api.test.tsto mocklogToChannelinstead ofOutputChannel.OutputChannelcreation fromvscode-impls.jsandvscode-context-stubs.ts.createClineAPI()inindex.tsto no longer requireOutputChannel.This description was created by
for 2e6face. You can customize this summary. It will automatically update as commits are pushed.