remove chatSettings object #5178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
42db4da to
9443ae1
Compare
arafatkatze
reviewed
Jul 28, 2025
arafatkatze
approved these changes
Jul 28, 2025
Coverage ReportExtension CoverageBase branch: 46% PR branch: 47% ✅ Coverage increased or remained the same Webview CoverageBase branch: 17% PR branch: 17% ✅ Coverage increased or remained the same Overall Assessment✅ Test coverage has been maintained or improved Last updated: 2025-07-29T19:19:37.049709 |
arafatkatze
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We remove the chatSettings object in favor of three flat fields, which it contained:
Mode, preferredLanguage, and openaiReasoningEffort.
These three fields were not related and should not have been grouped into an object.
This clears the way for further efforts related to our state.
Test Procedure
Test switching modes using both the plain act toggle and the two act mode button within the chat when Cline parses "act mode".
Test that images and text are still sent correctly with the Act Mode switch.
Test that preferred language is set and used by the model, and test that OpenAI reasoning effort is switched and saved correctly.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Additional Notes
Important
Refactor to replace
ChatSettingsobject with separatemode,preferredLanguage, andopenaiReasoningEffortfields, affecting state management, UI components, and API configurations.ChatSettingsobject withmode,preferredLanguage, andopenaiReasoningEffortfields across the codebase.togglePlanActModeto usemodedirectly instead ofChatSettings.ExtensionStateContextto managemode,preferredLanguage, andopenaiReasoningEffortseparately.getModeSpecificFieldsandnormalizeApiConfigurationto handle new fields.webview-ui/src/components/settings/providersto use new fields.ApiConfigurationSectionandFeatureSettingsSectionto reflect changes.ChatSettingsrelated files and functions, includingchat-settings-conversion.ts.This description was created by
for 54cd8e5. You can customize this summary. It will automatically update as commits are pushed.