Skip to content

Move vscode.commands.executeCommand("vscode.open") to Hostbridge #5173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2025
Merged

Move vscode.commands.executeCommand("vscode.open") to Hostbridge #5173

merged 5 commits into from
Jul 26, 2025

Conversation

kvyb
Copy link
Contributor

@kvyb kvyb commented Jul 26, 2025 •
edited by ellipsis-dev bot
Loading

Related Issue

Issue: #XXXX

Description

Simple migration of vscode.commands.executeCommand("vscode.open", ...) calls to hostbridge pattern.
This change:

  • Moves the vscode.open command into a hostbridge without changing any product logic
  • Affects only the openImage() function in open-file.ts where temp images are opened

Test Procedure

  • Verified code compiles and passes linting (npm run lint)
  • Manually tested that opening images still works as before
  • Confirmed no behavior changes - same functionality, different call path

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Refactor vscode.open command to use hostbridge pattern in openImage function, updating window.proto and maintaining functionality.

  • Refactor:
    • Move vscode.commands.executeCommand("vscode.open") to openFile function in openFile.ts.
    • Update openImage() in open-file.ts to use HostProvider.window.openFile().
  • Proto Changes:
    • Add openFile, getOpenTabs, and getVisibleTabs RPC methods to window.proto.
  • Testing:
    • Verified code compiles and passes linting.
    • Manually tested image opening functionality remains unchanged.

This description was created by Ellipsis for 53f680d. You can customize this summary. It will automatically update as commits are pushed.

kvyb added 2 commits July 24, 2025 07:01
@kvyb
feat: add openFile host bridge for vscode.open command
597901b
@kvyb
fix: simplify openFile hostbridge to follow gRPC best practices:
cca2d06 
- Remove success boolean field from OpenFileResponse proto
- Use gRPC exceptions for error handling instead of success/failure booleans
- Simplify hostbridge implementation to just move existing vscode.open code
@kvyb kvyb requested a review from sjf July 26, 2025 05:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: dc953cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sjf
sjf reviewed Jul 26, 2025
View reviewed changes
@kvyb kvyb requested a review from sjf July 26, 2025 07:12
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Extension Coverage

Base branch: 46%

PR branch: 47%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

Last updated: 2025-07-26T07:13:19.476834

@sjf sjf merged commit 195e15d into main Jul 26, 2025
13 checks passed
li-yechao pushed a commit to li-yechao/cline that referenced this pull request Jul 27, 2025
@kvyb @li-yechao
Move vscode.commands.executeCommand("vscode.open") to Hostbridge (cli…
e916d92 
…ne#5173)

* feat: add openFile host bridge for vscode.open command

* fix: simplify openFile hostbridge to follow gRPC best practices:
- Remove success boolean field from OpenFileResponse proto
- Use gRPC exceptions for error handling instead of success/failure booleans
- Simplify hostbridge implementation to just move existing vscode.open code

* fix: remove create wrapper from openFile call

* fix proto merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjf sjf sjf approved these changes

@saoudrizwan saoudrizwan Awaiting requested review from saoudrizwan

@ocasta181 ocasta181 Awaiting requested review from ocasta181

@NightTrek NightTrek Awaiting requested review from NightTrek

@pashpashpash pashpashpash Awaiting requested review from pashpashpash

@dcbartlett dcbartlett Awaiting requested review from dcbartlett

@saito-sv saito-sv Awaiting requested review from saito-sv

@Garoth Garoth Awaiting requested review from Garoth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvyb @sjf