Use npm module`open` to open URLs in the external browser (instead of the host bridge) #5013

sjf · 2025-07-18T07:26:08Z

cline-core can open the URLs directly without using the host bridge.

Use the npm module open.

Remove the openExternal implementation from the vscode-impls.

Update esbuild.js to ES6. I was not able to import the open module without making this change because of an imcompatibility between the module which is in CJS and the extension which is in ES6.

Related Issue

Test Procedure

Type of Change

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
♻️ Refactor Changes
💅 Cosmetic Changes
📚 Documentation update
🏃 Workflow Changes

Pre-flight Checklist

Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
I have created a changeset using npm run changeset (required for user-facing changes)
I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Replace host bridge URL opening with npm open module and update build to ES6.

Behavior:
- Replace host bridge method with npm open module for opening URLs in openExternal() in env.ts.
- Remove openExternal RPC method from env.proto.
- Update openInBrowser() in openInBrowser.ts to use new openExternal().
Build:
- Rename esbuild.js to esbuild.mjs and update to ES6 imports to support open module.
- Update package.json scripts to use esbuild.mjs.
Misc:
- Remove openExternal.ts from vscode-impls.js and related files.
- Add logging for errors in grpc-handler.ts.

^{This description was created by}^{for 4957c87. You can customize this summary. It will automatically update as commits are pushed.}

changeset-bot · 2025-07-18T07:26:12Z

⚠️ No Changeset found

Latest commit: f1baba1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

src/utils/env.ts

github-actions · 2025-07-25T06:15:35Z

Coverage Report

Extension Coverage

Base branch: 46%

PR branch: 47%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 17%

PR branch: 17%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

_{Last updated: 2025-07-26T07:56:49.824945}

abeatrix

I haven't tried the simple-open-url package before. but looking at their README.md:

This tool is used for a limited cross platform env usage, if you run command only on one platform, use the native open commands instead.

What error were you getting when you try to import open?

I tried replacing it with open and it worked for me if I update the path package to use the node protocol node:path

sjf · 2025-07-25T17:44:10Z

I haven't tried the simple-open-url package before. but looking at their README.md:

This tool is used for a limited cross platform env usage, if you run command only on one platform, use the native open commands instead.

We do need to run on multiple platforms.

What error were you getting when you try to import open?

I tried replacing it with open and it worked for me if I update the path package to use the node protocol node:path

I was just not able to get the import to work, any thing I tried to use from the open package was undefined.
I tried what you have here :/

sjf · 2025-07-25T17:48:53Z

I haven't tried the simple-open-url package before. but looking at their README.md:

This tool is used for a limited cross platform env usage, if you run command only on one platform, use the native open commands instead.

We do need to run on multiple platforms.

What error were you getting when you try to import open?
I tried replacing it with open and it worked for me if I update the path package to use the node protocol node:path

I was just not able to get the import to work, any thing I tried to use from the open package was undefined. I tried what you have here :/

import open from "open"
await open(url)
With this, when I load the extension I get this error

Can you show me how you got it to work?

src/utils/env.ts

abeatrix

verified the sign in flow still works

# Conflicts: # src/utils/env.ts # Conflicts: # src/utils/env.ts

Log failures of ProtoBus RPCs

Update esbuild.js to ES6 and move to esbuild.mjs

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

… the host bridge) (cline#5013) * Use npm `open` to open URLs in the external browser # Conflicts: # src/utils/env.ts # Conflicts: # src/utils/env.ts * Change log statement * Use the simple-open-url module to open URLs in the system browser. Log failures of ProtoBus RPCs * Remove vscode hostbridge handler for openExternal * Rm unused imports * Switch back to `open` module. Update esbuild.js to ES6 and move to esbuild.mjs * Update src/utils/env.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * remove IS_DEV from e2e setup build --------- Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> Co-authored-by: abeatrix <beatrix@cline.bot>

sjf requested review from saoudrizwan, ocasta181, NightTrek, pashpashpash, dcbartlett, saito-sv and Garoth as code owners July 18, 2025 07:26

sjf changed the title ~~Use npm open to open URLs in the external browser~~ Use npm moduleopen to open URLs in the external browser Jul 18, 2025

sjf force-pushed the sjf-j17o branch from 30c0864 to c597612 Compare July 18, 2025 20:23

abeatrix reviewed Jul 23, 2025

View reviewed changes

src/utils/env.ts Show resolved Hide resolved

abeatrix reviewed Jul 23, 2025

View reviewed changes

src/utils/env.ts Show resolved Hide resolved

sjf force-pushed the sjf-j17o branch from c597612 to 7d22405 Compare July 25, 2025 05:30

ellipsis-dev bot reviewed Jul 25, 2025

View reviewed changes

src/utils/env.ts Outdated Show resolved Hide resolved

sjf changed the title ~~Use npm moduleopen to open URLs in the external browser~~ Use npm modulesimple-open-http to open URLs in the external browser (instead of the host bridge) Jul 25, 2025

abeatrix requested changes Jul 25, 2025

View reviewed changes

sjf changed the title ~~Use npm modulesimple-open-http to open URLs in the external browser (instead of the host bridge)~~ Use npm moduleopen to open URLs in the external browser (instead of the host bridge) Jul 26, 2025

ellipsis-dev bot reviewed Jul 26, 2025

View reviewed changes

src/utils/env.ts Outdated Show resolved Hide resolved

sjf requested a review from abeatrix July 26, 2025 02:56

abeatrix approved these changes Jul 26, 2025

View reviewed changes

sjf and others added 7 commits July 26, 2025 03:47

Use npm open to open URLs in the external browser

4f17a52

# Conflicts: # src/utils/env.ts # Conflicts: # src/utils/env.ts

Change log statement

8dbc0d0

Use the simple-open-url module to open URLs in the system browser.

44a9106

Log failures of ProtoBus RPCs

Remove vscode hostbridge handler for openExternal

5c128b2

Rm unused imports

7d3aa41

Switch back to open module.

e1d0731

Update esbuild.js to ES6 and move to esbuild.mjs

Update src/utils/env.ts

b654fbc

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

remove IS_DEV from e2e setup build

f1baba1

sjf force-pushed the sjf-j17o branch from 4957c87 to f1baba1 Compare July 26, 2025 07:48

abeatrix approved these changes Jul 26, 2025

View reviewed changes

sjf merged commit 19cb70d into main Jul 26, 2025
13 checks passed

sjf deleted the sjf-j17o branch July 26, 2025 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use npm module`open` to open URLs in the external browser (instead of the host bridge) #5013

Use npm module`open` to open URLs in the external browser (instead of the host bridge) #5013

Uh oh!

sjf commented Jul 18, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

changeset-bot bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

abeatrix left a comment

Uh oh!

sjf commented Jul 25, 2025 •

edited

Loading

Uh oh!

sjf commented Jul 25, 2025

Uh oh!

Uh oh!

abeatrix left a comment

Uh oh!

Uh oh!

Uh oh!

Use npm moduleopen to open URLs in the external browser (instead of the host bridge) #5013

Use npm moduleopen to open URLs in the external browser (instead of the host bridge) #5013

Uh oh!

Conversation

sjf commented Jul 18, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Test Procedure

Type of Change

Pre-flight Checklist

Screenshots

Additional Notes

Uh oh!

changeset-bot bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Extension Coverage

Webview Coverage

Overall Assessment

Uh oh!

abeatrix left a comment

Choose a reason for hiding this comment

Uh oh!

sjf commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sjf commented Jul 25, 2025

Uh oh!

Uh oh!

abeatrix left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Use npm module`open` to open URLs in the external browser (instead of the host bridge) #5013

Use npm module`open` to open URLs in the external browser (instead of the host bridge) #5013

sjf commented Jul 18, 2025 •

edited by ellipsis-dev bot

Loading

changeset-bot bot commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 25, 2025 •

edited

Loading

sjf commented Jul 25, 2025 •

edited

Loading