Skip to content

Conversation

ddling
Copy link
Contributor

@ddling ddling commented Jul 21, 2025

2025-07-18.10.16.07.mov

Huawei Cloud MaaS:

https://console.huaweicloud.com/modelarts/?agencyId=5e8a9ac3d8b1455caa394e38e9225136&region=cn-southwest-2&locale=en-us#/model-studio/square

Huawei Cloud MaaS Open Source Models

截屏2025-07-18 10 30 59

Related Request

Discussions: #4379

Related Issue

Issue: #XXXX

Description

Test Procedure

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes


Important

Add Huawei Cloud MaaS as a new provider with full integration into API handling, state management, and UI components.

  • Behavior:
    • Add Huawei Cloud MaaS as a new provider in proto/models.proto and proto/state.proto.
    • Implement HuaweiCloudMaaSHandler in src/api/providers/huawei-cloud-maas.ts for API interactions.
    • Update createHandlerForProvider() in src/api/index.ts to support Huawei Cloud MaaS.
  • State Management:
    • Add huaweiCloudMaaSApiKey to SecretKey in state-keys.ts and manage it in state.ts.
    • Update ApiConfiguration in api.ts to include Huawei Cloud MaaS fields.
  • UI Components:
    • Add HuaweiCloudMaasProvider component in webview-ui/src/components/settings/providers/HuaweiCloudMaasProvider.tsx.
    • Update ApiOptions.tsx to include Huawei Cloud MaaS in the provider dropdown.
    • Modify providerUtils.ts to handle Huawei Cloud MaaS model selection and configuration.

This description was created by Ellipsis for 841712f. You can customize this summary. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Jul 21, 2025

🦋 Changeset detected

Latest commit: 41c1549

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
claude-dev Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ddling
Copy link
Contributor Author

ddling commented Jul 21, 2025

@celestial-vault help to review, thanks

Copy link
Contributor

@celestial-vault celestial-vault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid PR!

You did a great job of matching the existing patterns that we have, thank you!

Just a few comments to address, and then it looks like it's good to go.

@ddling
Copy link
Contributor Author

ddling commented Jul 23, 2025

Very solid PR!

You did a great job of matching the existing patterns that we have, thank you!

Just a few comments to address, and then it looks like it's good to go.

Thank you for your careful review, it seems that there is light ahead.

@ddling
Copy link
Contributor Author

ddling commented Jul 23, 2025

@celestial-vault I think all conversation are fixed, help to review again

Copy link
Contributor

@celestial-vault celestial-vault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. Let's just resolve the merge conflicts

@ddling
Copy link
Contributor Author

ddling commented Jul 26, 2025

Looks solid. Let's just resolve the merge conflicts

@celestial-vault hi, had resolved the merge conflicts, help to review

@ddling ddling requested a review from celestial-vault July 29, 2025 03:16
@celestial-vault celestial-vault merged commit 708b785 into cline:main Jul 29, 2025
8 checks passed
dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
Co-authored-by: kiwina <kiwina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants