Host bridge migration: showErrorMessage, showInformationMessage, showWarningMessage #4745

abeatrix · 2025-07-09T01:14:06Z

Related Issue

Issue: #XXXX

Description

Introduces the showMessage host API to the host bridge for displaying informational, warning, and error messages to the user in clients.

The changes include:

A new ShowMessageRequest and SelectedResponse message definition in proto/host/window.proto to define the request and response structure for showing messages.
A new file src/hosts/vscode/window/showMessage.ts that implements the showErrorMessage, showInformationMessage, and showWarningMessage functions. These functions use the VS Code API to display messages based on the ShowMessageRequest.
Update all current call sites to use the new implementations

Test Procedure

The behavior for showErrorMessage, showInformationMessage, showWarningMessage should remain unchanged.
Example - Click Reset Workspace State in debugger to confirm the window messages are showing up as expected:

Type of Change

🐛 Bug fix (non-breaking change which fixes an issue)
✨ New feature (non-breaking change which adds functionality)
💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
♻️ Refactor Changes
💅 Cosmetic Changes
📚 Documentation update
🏃 Workflow Changes

Pre-flight Checklist

Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
I have created a changeset using npm run changeset (required for user-facing changes)
I have reviewed contributor guidelines

Screenshots

Additional Notes

Important

Introduces a unified showMessage API for consistent message handling across the codebase, replacing direct VS Code message calls.

Behavior:
- Introduces showMessage API in proto/host/window.proto for displaying messages.
- Replaces vscode.window.showErrorMessage, showInformationMessage, and showWarningMessage with showMessage in createRuleFile.ts, deleteRuleFile.ts, index.ts, resetState.ts, updateDefaultTerminalProfile.ts, deleteAllTaskHistory.ts, deleteTasksWithIds.ts, index.ts (mentions), index.ts (webview), tasks.ts, extension.ts, showMessage.ts, commit-message-generator.ts, export-markdown.ts, open-file.ts, process-files.ts, and McpHub.ts.
API:
- Adds ShowMessageRequest, ShowMessageType, and SelectedResponse to proto/host/window.proto.
- Implements showMessage function in showMessage.ts to handle message display logic.
Misc:
- Updates message handling in various functions to use the new showMessage API for consistency and maintainability.

^{This description was created by}^{for 23d81d1. You can customize this summary. It will automatically update as commits are pushed.}

…owWarningMessage Introduces the `showMessage` host API to the VS Code extension, allowing the host to display informational, warning, and error messages to the user. The changes include: - A new `ShowMessageRequest` and `SelectedResponse` message definition in `proto/host/window.proto` to define the request and response structure for showing messages. - A new file `src/hosts/vscode/window/showMessage.ts` that implements the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions. These functions use the VS Code API to display messages based on the `ShowMessageRequest`. - Replace all current call sites with the new implementations

This commit introduces the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` host APIs to the VS Code extension. These APIs allow the host to display informational, warning, and error messages to the user. The changes include: - Added `ShowErrorMessageRequest`, `ShowInformationMessageRequest`, and `ShowWarningMessageRequest` message definitions in `proto/host/window.proto` to define the request structure for showing messages. - Added new files `src/hosts/vscode/window/showErrorMessage.ts`, `src/hosts/vscode/window/showInformationMessage.ts`, and `src/hosts/vscode/window/showWarningMessage.ts` that implement the corresponding functions. These functions use the VS Code API to display messages based on the provided message and options.

changeset-bot · 2025-07-09T01:14:10Z

⚠️ No Changeset found

Latest commit: 23d81d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot

Pull Request Overview

This PR refactors all direct vscode.window.show*Message calls to use the new host bridge API (showErrorMessage, showInformationMessage, showWarningMessage) and adds corresponding Protobuf definitions and wrapper implementations.

Introduces new wrapper functions in src/hosts/vscode/window and updates the Protobuf window.proto definitions.
Replaces all existing vscode.window.show*Message calls with the new host bridge calls across the codebase.
Updates tests and import statements to reference the new wrappers.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

File	Description
src/hosts/vscode/window/show*.ts	Added host bridge wrappers for error/info/warning messages
proto/host/window.proto	Defined `ShowErrorMessageRequest`, `ShowInformationMessageRequest`, `ShowWarningMessageRequest`, and shared message types
`*/.ts` (various)	Replaced direct VSCode UI calls with the new wrapper functions
src/test/extension.test.ts	Updated test cleanup to use `showInformationMessage` wrapper

src/hosts/vscode/window/showWarningMessage.ts

src/hosts/vscode/window/showInformationMessage.ts

src/hosts/vscode/window/showErrorMessage.ts

github-actions · 2025-07-09T01:22:46Z

Coverage Report

Extension Coverage

Base branch: 46%

PR branch: 46%

✅ Coverage increased or remained the same

Webview Coverage

Base branch: 13%

PR branch: 13%

✅ Coverage increased or remained the same

Overall Assessment

✅ Test coverage has been maintained or improved

_{Last updated: 2025-07-11T22:36:00.782521}

The `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions in `src/hosts/vscode/window/` have been refactored for simplification. - The functions now directly destructure the `modal`, `detail`, and `items` properties from the input object. - The VS Code API calls now directly pass the `modal` and `detail` options, and use the spread operator to pass the `items.options` array as additional arguments. This removes the need for conditional logic to construct the options object.

proto/host/window.proto

src/core/controller/file/deleteRuleFile.ts

src/integrations/git/commit-message-generator.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

…exts (cline#4745) (cline#4748) Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>

Garoth

Looks great! Thanks Bee

… bee/showMessage

arafatkatze

Quick stamp for reapprove after merge conflicts, did not review properly but it has been tested by andrei

…WarningMessage (cline#4745) * host bridge migration: showErrorMessage & showInformationMessage & showWarningMessage Introduces the `showMessage` host API to the VS Code extension, allowing the host to display informational, warning, and error messages to the user. The changes include: - A new `ShowMessageRequest` and `SelectedResponse` message definition in `proto/host/window.proto` to define the request and response structure for showing messages. - A new file `src/hosts/vscode/window/showMessage.ts` that implements the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions. These functions use the VS Code API to display messages based on the `ShowMessageRequest`. - Replace all current call sites with the new implementations * define the request structure This commit introduces the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` host APIs to the VS Code extension. These APIs allow the host to display informational, warning, and error messages to the user. The changes include: - Added `ShowErrorMessageRequest`, `ShowInformationMessageRequest`, and `ShowWarningMessageRequest` message definitions in `proto/host/window.proto` to define the request structure for showing messages. - Added new files `src/hosts/vscode/window/showErrorMessage.ts`, `src/hosts/vscode/window/showInformationMessage.ts`, and `src/hosts/vscode/window/showWarningMessage.ts` that implement the corresponding functions. These functions use the VS Code API to display messages based on the provided message and options. * Simplify showMessage functions and use options array The `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions in `src/hosts/vscode/window/` have been refactored for simplification. - The functions now directly destructure the `modal`, `detail`, and `items` properties from the input object. - The VS Code API calls now directly pass the `modal` and `detail` options, and use the spread operator to pass the `items.options` array as additional arguments. This removes the need for conditional logic to construct the options object. * wip: apply feedback * Update src/integrations/git/commit-message-generator.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * merge conflict --------- Co-authored-by: abeatrix <beatrix@cline.bot> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

celestial-vault · 2025-07-16T23:26:08Z

@abeatrix Could these be separate PRs in the future? 🙏 🙏

…WarningMessage (cline#4745) * host bridge migration: showErrorMessage & showInformationMessage & showWarningMessage Introduces the `showMessage` host API to the VS Code extension, allowing the host to display informational, warning, and error messages to the user. The changes include: - A new `ShowMessageRequest` and `SelectedResponse` message definition in `proto/host/window.proto` to define the request and response structure for showing messages. - A new file `src/hosts/vscode/window/showMessage.ts` that implements the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions. These functions use the VS Code API to display messages based on the `ShowMessageRequest`. - Replace all current call sites with the new implementations * define the request structure This commit introduces the `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` host APIs to the VS Code extension. These APIs allow the host to display informational, warning, and error messages to the user. The changes include: - Added `ShowErrorMessageRequest`, `ShowInformationMessageRequest`, and `ShowWarningMessageRequest` message definitions in `proto/host/window.proto` to define the request structure for showing messages. - Added new files `src/hosts/vscode/window/showErrorMessage.ts`, `src/hosts/vscode/window/showInformationMessage.ts`, and `src/hosts/vscode/window/showWarningMessage.ts` that implement the corresponding functions. These functions use the VS Code API to display messages based on the provided message and options. * Simplify showMessage functions and use options array The `showErrorMessage`, `showInformationMessage`, and `showWarningMessage` functions in `src/hosts/vscode/window/` have been refactored for simplification. - The functions now directly destructure the `modal`, `detail`, and `items` properties from the input object. - The VS Code API calls now directly pass the `modal` and `detail` options, and use the spread operator to pass the `items.options` array as additional arguments. This removes the need for conditional logic to construct the options object. * wip: apply feedback * Update src/integrations/git/commit-message-generator.ts Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> * merge conflict --------- Co-authored-by: abeatrix <beatrix@cline.bot> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

abeatrix added 2 commits July 8, 2025 17:37

Copilot AI review requested due to automatic review settings July 9, 2025 01:14

abeatrix requested review from saoudrizwan, ocasta181, NightTrek, pashpashpash, dcbartlett, saito-sv and Garoth as code owners July 9, 2025 01:14

Copilot AI reviewed Jul 9, 2025

View reviewed changes

src/hosts/vscode/window/showWarningMessage.ts Outdated Show resolved Hide resolved

src/hosts/vscode/window/showInformationMessage.ts Outdated Show resolved Hide resolved

src/hosts/vscode/window/showErrorMessage.ts Outdated Show resolved Hide resolved

dcbartlett force-pushed the main branch from e1e27bd to 0098afc Compare July 9, 2025 01:19

Garoth requested changes Jul 9, 2025

View reviewed changes

proto/host/window.proto Outdated Show resolved Hide resolved

proto/host/window.proto Outdated Show resolved Hide resolved

proto/host/window.proto Outdated Show resolved Hide resolved

src/core/controller/file/deleteRuleFile.ts Outdated Show resolved Hide resolved

dcbartlett force-pushed the main branch from cc68ff0 to 988b65f Compare July 9, 2025 01:41

wip: apply feedback

e3fa1cd

ellipsis-dev bot reviewed Jul 9, 2025

View reviewed changes

src/integrations/git/commit-message-generator.ts Outdated Show resolved Hide resolved

Update src/integrations/git/commit-message-generator.ts

9e65510

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

abeatrix force-pushed the bee/showMessage branch from f284a87 to 9e65510 Compare July 9, 2025 23:50

abeatrix requested a review from Garoth July 10, 2025 00:55

ARQAWA pushed a commit to ARQAWA/cline that referenced this pull request Jul 10, 2025

fix: improve Bedrock error handling for throttling and streaming cont…

ee751af

…exts (cline#4745) (cline#4748) Co-authored-by: Daniel Riccio <ricciodaniel98@gmail.com>

Garoth previously approved these changes Jul 11, 2025

View reviewed changes

abeatrix added 2 commits July 11, 2025 15:12

Merge branch 'main' into bee/showMessage

71f19d3

Merge branch 'bee/showMessage' of https://github.com/cline/cline into…

360c845

… bee/showMessage

abeatrix dismissed Garoth’s stale review via 360c845 July 11, 2025 22:15

merge conflict

23d81d1

abeatrix requested a review from Garoth July 11, 2025 23:49

arafatkatze approved these changes Jul 12, 2025

View reviewed changes

abeatrix merged commit 16f066d into main Jul 12, 2025
9 checks passed

abeatrix deleted the bee/showMessage branch July 16, 2025 23:50

canvrno mentioned this pull request Jul 30, 2025

Fix: Obey delete task popup cancel #5260

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Host bridge migration: showErrorMessage, showInformationMessage, showWarningMessage #4745

Host bridge migration: showErrorMessage, showInformationMessage, showWarningMessage #4745

Uh oh!

abeatrix commented Jul 9, 2025 •

edited by ellipsis-dev bot

Loading

Uh oh!

changeset-bot bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Garoth left a comment

Uh oh!

arafatkatze left a comment •

edited

Loading

Uh oh!

Uh oh!

celestial-vault commented Jul 16, 2025

Uh oh!

Uh oh!

Host bridge migration: showErrorMessage, showInformationMessage, showWarningMessage #4745

Host bridge migration: showErrorMessage, showInformationMessage, showWarningMessage #4745

Uh oh!

Conversation

abeatrix commented Jul 9, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Description

Test Procedure

Type of Change

Pre-flight Checklist

Screenshots

Additional Notes

Uh oh!

changeset-bot bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Extension Coverage

Webview Coverage

Overall Assessment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Garoth left a comment

Choose a reason for hiding this comment

Uh oh!

arafatkatze left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

celestial-vault commented Jul 16, 2025

Uh oh!

Uh oh!

abeatrix commented Jul 9, 2025 •

edited by ellipsis-dev bot

Loading

changeset-bot bot commented Jul 9, 2025 •

edited

Loading

github-actions bot commented Jul 9, 2025 •

edited

Loading

arafatkatze left a comment •

edited

Loading