Skip to content

Do not ignore pkg folder (#4483) #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Do not ignore pkg folder (#4483) #4505

merged 1 commit into from
Jul 31, 2025

Conversation

akshaybabloo
Copy link
Contributor

@akshaybabloo akshaybabloo commented Jun 27, 2025 •
edited
Loading

Related Issue

closes #4483

Description

In Go, pkg is used to add general/common code used across the code base. Ignoring this causes Cline not to list any files in the pkg folder.

Test Procedure

  1. Create a new Go project with main.go under . folder
  2. Create a folder called pkg/ without any files in it
  3. Under pkg/ create a new folder with file called hello/default.go (or anything)
  4. Import the code into main.go
  5. Instruct Cline to give you feedback

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

N/A

Additional Notes

N/A

Important

Removes pkg from ignore list in list-files.ts, allowing files in pkg directory to be listed.

  • Behavior:
    • Removes pkg from DEFAULT_IGNORE_DIRECTORIES in list-files.ts, allowing files in pkg directory to be listed.
  • Testing:
    • Tested by creating a Go project with a pkg directory and verifying files are listed.

This description was created by Ellipsis for 70e1eb1. You can customize this summary. It will automatically update as commits are pushed.

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 03:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2b49178

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
claude-dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

This comment was marked as outdated.

Sign in to view

@akshaybabloo akshaybabloo requested a review from Copilot July 3, 2025 22:12
Copilot
Copilot AI reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that files within the pkg directory are no longer ignored when listing project files.

  • Removed pkg from the default ignore list in the globbing service
  • Added a changeset to document this bugfix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/services/glob/list-files.ts Removed "pkg" from DEFAULT_IGNORE_DIRECTORIES to allow including files under pkg
.changeset/perfect-buses-talk.md Created a patch changeset summarizing the removal of pkg from ignores
Comments suppressed due to low confidence (2)

src/services/glob/list-files.ts:20

  • Add or update tests to cover listing files in the pkg directory to ensure this change behaves as expected.
	"deps",

.changeset/perfect-buses-talk.md:2

  • The changeset references claude-dev as the package name; ensure this matches the actual package name (e.g., cline) in your repository configuration.
"claude-dev": patch

@akshaybabloo
Copy link
Contributor Author

Any update on this please?

@saoudrizwan
Copy link
Contributor

Hey @akshaybabloo thank you so much for the contribution! I agree that pkg should not be part of this ignored list. Can you pls also remove it from src/integrations/checkpoints/CheckpointExclusions.ts? Thank you 🙏

@akshaybabloo
Copy link
Contributor Author

@saoudrizwan Done

@0xToshii 0xToshii merged commit c8abcbf into cline:main Jul 31, 2025
8 checks passed
@0xToshii
Copy link
Contributor

this has been updated!

dtrugman pushed a commit to dtrugman/cline that referenced this pull request Aug 24, 2025
@elianiva
chore: add data-testid rule (cline#4505)
bfeb12b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@0xToshii 0xToshii 0xToshii approved these changes

@saoudrizwan saoudrizwan Awaiting requested review from saoudrizwan

@ocasta181 ocasta181 Awaiting requested review from ocasta181

@NightTrek NightTrek Awaiting requested review from NightTrek

@pashpashpash pashpashpash Awaiting requested review from pashpashpash

@dcbartlett dcbartlett Awaiting requested review from dcbartlett

@saito-sv saito-sv Awaiting requested review from saito-sv

@Garoth Garoth Awaiting requested review from Garoth

Assignees

@0xToshii 0xToshii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to do a recursive search
3 participants
@akshaybabloo @saoudrizwan @0xToshii