Skip to content

Conversation

williammartin
Copy link
Member

@williammartin williammartin commented Jul 23, 2024

Description

Fixes #9278

Acceptance Criteria

Given there is a release with on
When I run gh release view --repo <repo> --json name,databaseId <tag>
Then I see a JSON document containing an integer database Id for the release

➜ ./bin/gh release list --repo cli/cli | cat
GitHub CLI 2.53.0        Latest  v2.53.0 2024-07-17T18:51:32Z
...
➜ ./bin/gh release view --repo cli/cli --json name,databaseId v2.53.0 | cat
{"databaseId":165912183,"name":"GitHub CLI 2.53.0"}

"id",
"tagName",
"name",
"author",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is both an alphabetising and the addition of databaseId. You can see the individual commits for clarity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always about alphabetizing, helps find duplicates

@williammartin williammartin force-pushed the 9278-gh-release-view-with-json-parser-outputs-node_id-instead-of-id branch from 784ce43 to c13d161 Compare July 23, 2024 11:42
Copy link
Member

@andyfeller andyfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyfeller andyfeller merged commit 78c3361 into trunk Jul 23, 2024
@andyfeller andyfeller deleted the 9278-gh-release-view-with-json-parser-outputs-node_id-instead-of-id branch July 23, 2024 14:06
izumin5210 referenced this pull request in izumin5210/dotfiles Aug 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cli/cli](https://togithub.com/cli/cli) | minor | `v2.53.0` ->
`v2.54.0` |

---

### Release Notes

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.54.0`](https://togithub.com/cli/cli/releases/tag/v2.54.0):
GitHub CLI 2.54.0

[Compare Source](https://togithub.com/cli/cli/compare/v2.53.0...v2.54.0)

#### What's Changed

- Remove redundant whitespace by
[@&#8203;jessehouwing](https://togithub.com/jessehouwing) in
[https://github.com/cli/cli/pull/9334](https://togithub.com/cli/cli/pull/9334)
- Remove attestation test that requires being online by
[@&#8203;steiza](https://togithub.com/steiza) in
[https://github.com/cli/cli/pull/9340](https://togithub.com/cli/cli/pull/9340)
- Update documentation for gh api PATCH by
[@&#8203;cmbuckley](https://togithub.com/cmbuckley) in
[https://github.com/cli/cli/pull/9352](https://togithub.com/cli/cli/pull/9352)
- Clarify usage of template flags for PR and issue creation by
[@&#8203;williammartin](https://togithub.com/williammartin) in
[https://github.com/cli/cli/pull/9354](https://togithub.com/cli/cli/pull/9354)
- Expose json databaseId field for release commands by
[@&#8203;williammartin](https://togithub.com/williammartin) in
[https://github.com/cli/cli/pull/9356](https://togithub.com/cli/cli/pull/9356)
- Expose fullDatabaseId for PR json export by
[@&#8203;williammartin](https://togithub.com/williammartin) in
[https://github.com/cli/cli/pull/9355](https://togithub.com/cli/cli/pull/9355)
- Handle `--bare` clone targets by
[@&#8203;hyperrealist](https://togithub.com/hyperrealist) in
[https://github.com/cli/cli/pull/9271](https://togithub.com/cli/cli/pull/9271)
- Slightly clarify when CLI exits with code 4 by
[@&#8203;williammartin](https://togithub.com/williammartin) in
[https://github.com/cli/cli/pull/9358](https://togithub.com/cli/cli/pull/9358)
- Update sigstore-go in gh CLI to v0.5.1 by
[@&#8203;steiza](https://togithub.com/steiza) in
[https://github.com/cli/cli/pull/9366](https://togithub.com/cli/cli/pull/9366)
- Exit with 1 on authentication issues by
[@&#8203;Stausssi](https://togithub.com/Stausssi) in
[https://github.com/cli/cli/pull/9240](https://togithub.com/cli/cli/pull/9240)
- build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.4 to
1.4.5 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/cli/cli/pull/9372](https://togithub.com/cli/cli/pull/9372)
- build(deps): bump github.com/google/go-containerregistry from 0.20.0
to 0.20.1 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/cli/cli/pull/9373](https://togithub.com/cli/cli/pull/9373)
- Add `--remove-milestone` option to `issue edit` and `pr edit` by
[@&#8203;babakks](https://togithub.com/babakks) in
[https://github.com/cli/cli/pull/9344](https://togithub.com/cli/cli/pull/9344)
- handle attest case insensitivity by
[@&#8203;ejahnGithub](https://togithub.com/ejahnGithub) in
[https://github.com/cli/cli/pull/9392](https://togithub.com/cli/cli/pull/9392)

#### New Contributors

- [@&#8203;cmbuckley](https://togithub.com/cmbuckley) made their first
contribution in
[https://github.com/cli/cli/pull/9352](https://togithub.com/cli/cli/pull/9352)
- [@&#8203;hyperrealist](https://togithub.com/hyperrealist) made their
first contribution in
[https://github.com/cli/cli/pull/9271](https://togithub.com/cli/cli/pull/9271)
- [@&#8203;Stausssi](https://togithub.com/Stausssi) made their first
contribution in
[https://github.com/cli/cli/pull/9240](https://togithub.com/cli/cli/pull/9240)
- [@&#8203;ejahnGithub](https://togithub.com/ejahnGithub) made their
first contribution in
[https://github.com/cli/cli/pull/9392](https://togithub.com/cli/cli/pull/9392)

**Full Changelog**: cli/cli@v2.53.0...v2.54.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/izumin5210/dotfiles).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: izumin5210-update-aqua-checksum[bot] <169593670+izumin5210-update-aqua-checksum[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH release view with JSON parser outputs node_id instead of id
2 participants