-
Notifications
You must be signed in to change notification settings - Fork 7k
Closed
Labels
help wantedContributions welcomeContributions welcometech-debtA chore that addresses technical debtA chore that addresses technical debt
Description
Description
Whilst writing the release deep dive doc I noticed that our ./script/sign
script still has references to signing for windows. However, I do not believe that this codepath is exercised anymore, since we moved to Azure HSM:
cli/.github/workflows/deployment.yml
Lines 238 to 240 in fc19ff3
Get-ChildItem -Path .\dist -Filter *.msi | ForEach-Object { | |
.\script\sign.ps1 $_.FullName | |
} |
Expected Output
The expected output for this issue is:
- The windows signing sections are removed from
./script/sign
(including the loop which decides to callsign_windows
- The
goreleaser.yml
does not reference./script/sign
- The release deep dive doc warning about this issue under the "Windows" section is removed
andyfeller and iamazeemandyfeller
Metadata
Metadata
Assignees
Labels
help wantedContributions welcomeContributions welcometech-debtA chore that addresses technical debtA chore that addresses technical debt