Skip to content

./script/sign seems to have unnecessary windows signing debris #10559

@williammartin

Description

@williammartin

Description

Whilst writing the release deep dive doc I noticed that our ./script/sign script still has references to signing for windows. However, I do not believe that this codepath is exercised anymore, since we moved to Azure HSM:

Get-ChildItem -Path .\dist -Filter *.msi | ForEach-Object {
.\script\sign.ps1 $_.FullName
}

Expected Output

The expected output for this issue is:

  • The windows signing sections are removed from ./script/sign (including the loop which decides to call sign_windows
  • The goreleaser.yml does not reference ./script/sign
  • The release deep dive doc warning about this issue under the "Windows" section is removed

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedContributions welcometech-debtA chore that addresses technical debt

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions