feat!: introducing sleeping status #773
Merged
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
Marking this commit as breaking since a CustomResourceDefinition update is required for users dealing with scale to zero since the introduction of the new enum for the status field. Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
c75cc64 to
61c2d80
Compare
|
LGTM. Should update the KamajiControlPlane controller part to treat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kamaji already offers a scale-to-zero feature, which had some bugs prior to #771.
A TenantControlPlane, although scaled to zer,o was always marked as
Readyeven tho this was inaccurate, bringing some errors when scaling back to a positive amount of replicas, and logging false positive errors since the API Server wasn't yet ready from the Soot manager due to new pods being rolled out.This PR introduces the new status enum
Sleeping, useful to inform operators if a Tenant Control Plane is scaled to zero.Marking the commit as important since a Custom Resource Definition update must be applied.