Skip to content

test: add scale to zero e2e test #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

test: add scale to zero e2e test #776

merged 3 commits into from
Apr 8, 2025

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Apr 8, 2025

No description provided.

test: add scale to zero e2e test
9496b9b 
Signed-off-by: Mario Valderrama <mario.valderrama@ionos.com>
@netlify Netlify
Copy link

netlify bot commented Apr 8, 2025 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 14a054d
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67f51a855c7d5f0008a6eeef

@avorima
Copy link
Contributor Author

avorima commented Apr 8, 2025

This error secrets is forbidden: User \"kubernetes-admin\" cannot create resource \"secrets\" in API group \"\" in the namespace \"kube-system\" looks suspiciously like the one that I thought I had fixed in #771.

@prometherion
Copy link
Member

@avorima I guess we're root cause is about this one:

kamaji/e2e/worker_kubeadm_join_test.go

Lines 133 to 143 in 97d87b6

By("generating kubeadm join command", func() {
joinCommandBuffer = bytes.NewBufferString("")
config, err := clientcmd.BuildConfigFromFlags("", kubeconfigFile.Name())
Expect(err).ToNot(HaveOccurred())
clientset, err := kubernetes.NewForConfig(config)
Expect(err).ToNot(HaveOccurred())
Expect(cmd.RunCreateToken(joinCommandBuffer, clientset, "", &kubeadmv1beta4.InitConfiguration{}, true, "", kubeconfigFile.Name())).ToNot(HaveOccurred())
})

Essentially, the Soot Controller is not as quick as we're expecting, meaning the RBAC has not yet been installed. We can add an Eventually condition, or check the Status=Ready or the Addon one.

LEt me know if you want to add this to your PR, or should I open a new one so you can rebase overit.

@avorima avorima marked this pull request as ready for review April 8, 2025 13:10
@avorima
Copy link
Contributor Author

avorima commented Apr 8, 2025

@prometherion i made some changes. let me know what you think

prometherion
prometherion approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the PR increasing test coverage ❤️ LGTM!

@prometherion prometherion merged commit c769226 into clastix:master Apr 8, 2025
11 checks passed
@avorima avorima deleted the scale-e2e-test branch April 8, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avorima @prometherion