Skip to content

fix: wait until deployment stabilizes to set status Ready #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: wait until deployment stabilizes to set status Ready #718

merged 1 commit into from
Mar 12, 2025

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Mar 11, 2025

I noticed some connection interruptions when connecting to the kube-apiserver after a version update.
This change aims to improve this by making sure that all pods are updated and ready before marking the version status as Ready.

fix: wait until deployment stabilizes to set status Ready
0406f63 
Signed-off-by: Mario Valderrama <mario.valderrama@ionos.com>
@avorima avorima force-pushed the fix-version-ready branch from 0067e2b to 0406f63 Compare March 11, 2025 09:13
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 0067e2b
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67cffec2841281000826ea69

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 0406f63
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67cffed37e371c0008dc52fa

@avorima avorima marked this pull request as ready for review March 11, 2025 09:35
prometherion
prometherion reviewed Mar 11, 2025
View reviewed changes
@prometherion prometherion merged commit d5ed4db into clastix:master Mar 12, 2025
10 checks passed
@avorima avorima deleted the fix-version-ready branch March 12, 2025 12:29
@avorima avorima mentioned this pull request Jun 11, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avorima @prometherion