Skip to content

refactor: avoid logging error and sentinel for status #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

refactor: avoid logging error and sentinel for status #673

merged 1 commit into from
Jan 22, 2025

Conversation

prometherion
Copy link
Member

Closes #664.

The resulting logs when the LoadBalancer IP is not yet exposed:

2025-01-21T19:03:45+01:00       INFO    Starting Controller     {"controller": "secret", "controllerGroup": "", "controllerKind": "Secret"}
2025-01-21T19:03:45+01:00       INFO    Starting workers        {"controller": "secret", "controllerGroup": "", "controllerKind": "Secret", "worker count": 1}
2025-01-21T19:03:45+01:00       INFO    Starting Controller     {"controller": "datastore", "controllerGroup": "kamaji.clastix.io", "controllerKind": "DataStore"}
2025-01-21T19:03:45+01:00       INFO    Starting workers        {"controller": "datastore", "controllerGroup": "kamaji.clastix.io", "controllerKind": "DataStore", "worker count": 1}
2025-01-21T19:03:45+01:00       INFO    Starting Controller     {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane"}
2025-01-21T19:03:45+01:00       INFO    Starting workers        {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "worker count": 1}
2025-01-21T19:03:45+01:00       INFO    Starting Controller     {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane"}
2025-01-21T19:03:45+01:00       INFO    Starting workers        {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "worker count": 1}
2025-01-21T19:04:05+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "605841d9-1310-4b38-8eea-5e28a863ab0e", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}
2025-01-21T19:04:33+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "8d17b0bf-18b9-4daf-93de-6071b55737b4", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}
2025-01-21T19:04:34+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "a54ee157-8e32-4a14-9e45-1900e65c5d42", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}
2025-01-21T19:04:34+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "58885d0c-fb1e-463f-805b-9015cd6fe0cc", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}
2025-01-21T19:04:34+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "d66c802b-410b-487e-9dad-b69ca3531b25", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}
2025-01-21T19:04:34+01:00       DEBUG   sentinel error, enqueuing back request  {"controller": "tenantcontrolplane", "controllerGroup": "kamaji.clastix.io", "controllerKind": "TenantControlPlane", "TenantControlPlane": {"name":"k8s-130","namespace":"default"}, "namespace": "default", "name": "k8s-130", "reconcileID": "2aae56ff-1444-43f0-bd21-519cd23daa19", "error": "error applying TenantcontrolPlane status: cannot retrieve the TenantControlPlane address, Service resource is not yet exposed as LoadBalancer"}

@prometherion
refactor: avoid logging error and sentinel for status
0940369 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 0940369
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/678fe20f6e6b3c000874a4cc

@prometherion prometherion merged commit 1d72802 into clastix:master Jan 22, 2025
10 checks passed
@prometherion prometherion deleted the issues/664 branch January 22, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCP Creation results in multiple errors in Kamaji controller
1 participant
@prometherion