fix latest power usage calculation #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the latest power usage calculation by switching from using the first element of powerHistory to the latest sample based on a computed sample range.
- Introduces computeSampleRange to determine the appropriate index for the latest power reading
- Adjusts the metric emission to utilize the computed sample index
Comments suppressed due to low confidence (1)
internal/exporter/exporter.go:599
- [nitpick] The variable name 'latest_range' does not follow Go's camelCase naming conventions. Consider renaming it to 'latestRange'.
latest_range, _, _ := computeSampleRange(history, 1)
| powerHistory := history.GetPowerIn() | ||
|
|
||
| latest_range, _, _ := computeSampleRange(history, 1) |
There was a problem hiding this comment.
Accessing latest_range[0] without checking if the slice is non-empty may lead to a runtime panic. Consider adding a check to ensure the slice contains at least one element.
Suggested change
| latest_range, _, _ := computeSampleRange(history, 1) | |
| latest_range, _, _ := computeSampleRange(history, 1) | |
| if len(latest_range) == 0 { | |
| log.Errorf("computeSampleRange returned an empty range; unable to process latest power data") | |
| return false | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.