Fullscreen: fixes after testing #18191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --ck-z-panel: calc(var(--ck-z-default) + 999); | ||
| --ck-z-dialog: 100000; | ||
|
|
||
| /* CKBox wrapper has z-index of 9999, let's bump it over the dialog's to ensure visibility like outside fullscreen mode. */ |
There was a problem hiding this comment.
Shouldn't we add an integration for CKBox that will add an additional CSS class?
There was a problem hiding this comment.
AFAICS there is no such configuration option, so changing a variable value seems like an expected way to customize the dialog?
There was a problem hiding this comment.
I was considering whether we could extend the CKBox initialization to add an additional CSS class, but I haven’t checked it yet. If it’s not possible, we can skip it.
Co-authored-by: Dawid Kossowski <20561161+DawidKossowski@users.noreply.github.com>
93d952f to
02aa7a3
Compare
DawidKossowski
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (fullscreen): Integrate with CKBox. Closes #18189.
Internal (fullscreen): Fix dialogs and balloons positioning in scrollable container. Closes #18153.
Internal (fullscreen): Remove icon and rename fullscreen menu bar. Closes #18187.
Internal (fullscreen): Rename fullscreen toolbar buttons to "Enter/leave fullscreen mode". Closes #18188.
Additional information
Other issues that should work on this branch (were fixed in the meantime):