Skip to content

Improve source editing integration with document outline in fullscreen mode #18165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Improve source editing integration with document outline in fullscreen mode #18165

merged 4 commits into from
Mar 24, 2025

Conversation

Dumluregn
Copy link
Contributor

@Dumluregn Dumluregn commented Mar 19, 2025 •
edited
Loading

Suggested merge commit message (convention)

Internal (fullscreen): Improve source editing integration with document outline in fullscreen mode.

Additional information

  1. Source editing integration was not perfect, it didn't take into account a situation when there are multiple document outline containers on the page.
  2. Fullscreen has to detect when source mode is open and toggle "Document outline" header visibility.

Base automatically changed from ck/fullscreen-toolbar-switching to ck/fullscreen-guide March 19, 2025 16:22
DawidKossowski
DawidKossowski reviewed Mar 24, 2025
View reviewed changes
@Dumluregn Dumluregn merged commit 83188b6 into ck/fullscreen-guide Mar 24, 2025
1 of 2 checks passed
@Dumluregn Dumluregn deleted the ck/fullscreen-source-editing-document-outline branch March 24, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidKossowski DawidKossowski DawidKossowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dumluregn @DawidKossowski