Table type toggling feature #18135
Merged
Table type toggling feature #18135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
requested changes
Mar 17, 2025
packages/ckeditor5-table/src/tablelayout/commands/tabletypecommand.ts
Outdated
Show resolved
Hide resolved
niegowski
requested changes
Mar 17, 2025
godai78
reviewed
Mar 18, 2025
niegowski
requested changes
Mar 18, 2025
packages/ckeditor5-table/tests/tablelayout/commands/tabletypecommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablelayout/commands/tabletypecommand.js
Outdated
Show resolved
Hide resolved
…ommand.js Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
…ommand.js Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Base automatically changed from
ck/set-table-type-command
to
ck/epic/email-editing
March 18, 2025 13:58
pszczesniak
reviewed
Mar 18, 2025
niegowski
reviewed
Mar 18, 2025
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
Co-authored-by: Kuba Niegowski <1232187+niegowski@users.noreply.github.com>
|
Specific glitch: if there is nothing above the table in the demo and the The table toolbar works fine. The main editor toolbar button works fine, if there is anything above the table in the demo. |
niegowski
reviewed
Mar 19, 2025
niegowski
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (table): Add ability to change table type to the layout table using balloon toolbar. Closes #18131
Additional information
Parent PR #18109