Introduce a fullscreen mode feature #18057
Conversation
… into epic/1235-fullscreen-mode-presence-list
… into epic/1235-fullscreen-mode-presence-list
There was a problem hiding this comment.
Some questions, suggestions for API changes, and one change required related to RH integration (passing config to callback).
In overall, I was a bit surprised with how you implemented RH integration. You let things happen "in original place" and then move back these items from the original place to fullscreen. That's an interesting idea, maybe better than I thought it will be done - I just expected something different. It may actually be good for customized RH integrations, but I guess time will tell.
Since fullscreen supports decoupled editor, and AFAIR decoupled editor requires customized RH integration, I assume this was tested and basic RH custom integrations are supported. This is enough for me at this point.
packages/ckeditor5-fullscreen/src/handlers/decouplededitorhandler.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-fullscreen/src/handlers/abstracteditorhandler.ts
Outdated
Show resolved
Hide resolved
packages/ckeditor5-fullscreen/src/handlers/abstracteditorhandler.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Szymon Cofalik <s.cofalik@cksource.com>
|
🎉 I came to this repository to find out if full-screen was supported, found my way to this MR, and had the pleasure of seeing this merged in real-time 😄 🥳 |
Suggested merge commit message (convention)
Feature (fullscreen): Introduced the fullscreen mode feature. Closes #18026.
Feature (ui): Added
MenuBarView#disable()andMenuBarView#enable()methods. They disable/enable all top-level menus in menu bar. Closes #17940.Feature (ui): Added
ToolbarView#switchBehavior()to switch toolbar behavior after the editor has been initialized. Closes #18159.Fix (ui): Do not open disabled menu bar menu on arrow down press. Closes #17915.
Other (source-editing): Document outline and annotations will now be hidden when editor is in source editing mode. Closes #17978.
Docs (fullscreen): Add feature guide.