Skip to content

Fix font color picker not working properly on first change on Chrome #17109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix font color picker not working properly on first change on Chrome #17109

merged 5 commits into from
Feb 11, 2025

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 17, 2024 •
edited
Loading

Suggested merge commit message (convention)

Fix (ui): Fixed an issue where the first selected color was applied instead of the second selected color when using the font color picker for the first time after loading the page. Closes #17069

Additional information

Before

before-picker-fix-2024-09-18_07.50.43.mp4

After

after-picker-fix-2024-09-18_07.48.13.mp4

@Mati365 Mati365 marked this pull request as ready for review September 18, 2024 05:51
@Mati365 Mati365 force-pushed the ck/17069 branch 2 times, most recently from aa68532 to d5c9199 Compare September 19, 2024 08:41
@Mati365 Mati365 mentioned this pull request Jan 20, 2025
Closed
@Mati365 Mati365 requested review from pszczesniak, gorzelinski and mmotyczynska and removed request for niegowski January 22, 2025 06:39
@dil-bparihar
Copy link

Yes it is an issue. When this PR will be merged and deployed. @arkflpc

arkflpc
arkflpc reviewed Jan 23, 2025
View reviewed changes
@Mati365 Mati365 force-pushed the ck/17069 branch 2 times, most recently from de917bc to e6b3d86 Compare January 23, 2025 14:28
gorzelinski
gorzelinski reviewed Feb 3, 2025
View reviewed changes
@gorzelinski gorzelinski self-requested a review February 3, 2025 08:40
gorzelinski
gorzelinski previously approved these changes Feb 3, 2025
View reviewed changes
@dil-bparihar
Copy link

@Mati365 when we are going to merge it ?

@Mati365 Mati365 marked this pull request as draft February 10, 2025 06:25
@Mati365 Mati365 marked this pull request as ready for review February 10, 2025 10:02
@Mati365 Mati365 requested a review from arkflpc February 10, 2025 10:56
gorzelinski
gorzelinski reviewed Feb 10, 2025
View reviewed changes
mmotyczynska
mmotyczynska approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is much better than the previous one, and seems to work well 👍

@Mati365 Mati365 merged commit a0b28c0 into master Feb 11, 2025
9 checks passed
@Mati365 Mati365 deleted the ck/17069 branch February 11, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorzelinski gorzelinski gorzelinski left review comments

@mmotyczynska mmotyczynska mmotyczynska approved these changes

@pszczesniak pszczesniak Awaiting requested review from pszczesniak

@arkflpc arkflpc Awaiting requested review from arkflpc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font color picker not working properly on first change
5 participants
@Mati365 @dil-bparihar @arkflpc @gorzelinski @mmotyczynska