Avoid unnecessary type conversions #55

ckaznocha · 2025-03-20T22:38:08Z

closes #49

Copilot

Pull Request Overview

This PR aims to avoid unnecessary type conversions by short-circuiting conversion calls when the operand’s type already matches the target type.

In intrange.go, a check is added to return the original string if the operand’s type is equivalent to the conversion type.
In testdata/main.go, a new function issue49 demonstrates a for loop that could be improved using Go 1.22+ integer ranges.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
intrange.go	Added a type-check block to bypass redundant type conversion.
testdata/main.go	Added a new function (issue49) with a for loop that can use integer range.

Files not reviewed (1)

intrange.go

ckaznocha requested a review from Copilot March 20, 2025 22:38

ckaznocha self-assigned this Mar 20, 2025

Copilot AI reviewed Mar 20, 2025

View reviewed changes

intrange.go Outdated Show resolved Hide resolved

Avoid nnecessary type conversions

c05cdca

ckaznocha force-pushed the ckaznocha/issue49 branch from b966e0a to c05cdca Compare March 20, 2025 22:39

ckaznocha changed the title ~~Avoid nnecessary type conversions~~ Avoid unnecessary type conversions Mar 20, 2025

ckaznocha merged commit f53ac9f into main Mar 20, 2025
8 checks passed

ckaznocha deleted the ckaznocha/issue49 branch March 20, 2025 22:41