Do not autofix functions and methods #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that functions and methods are not automatically fixed by updating diagnostic checks when key values are computed via function or method calls. It also streamlines length and integer cast checks by consolidating repeated logic into helper functions.
- Introduces a new check in checkForStmt that reports when a function or method call is used for the loop key.
- Refactors checks in checkRangeStmt, findNExpr, and number literal evaluations to use isLen and isIntCast.
- Adds helper functions: isFunctionOrMethodCall, isIntCast, and isLen.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| intrange.go | Adds enhanced diagnostic reporting for function/method-based keys and refactors checks. |
| testdata/main.go | Adds test case issue48 to illustrate the new behavior when a function/method is used. |
Files not reviewed (1)
- testdata/main.go.golden: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #48