Skip to content

Update range autofix #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2024
Merged

Update range autofix #35

merged 2 commits into from
Nov 9, 2024

Conversation

ckaznocha
Copy link
Owner

  • Linter passing
  • Support binary expressions in the operand
  • Drop unnecessary casts
  • Add more test cases

Still TODO: handle loops where the key is not accessed in the body

@ckaznocha ckaznocha requested a review from Copilot November 9, 2024 22:50
@ckaznocha ckaznocha self-assigned this Nov 9, 2024
Copilot
Copilot AI reviewed Nov 9, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 suggestions.

Files not reviewed (1)
  • testdata/main.go.golden: Language not supported

@ckaznocha ckaznocha merged commit cd7c74e into main Nov 9, 2024
8 checks passed
@ckaznocha ckaznocha deleted the clif/auto-fix-range branch November 9, 2024 22:58
@ckaznocha ckaznocha mentioned this pull request Nov 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@ckaznocha ckaznocha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ckaznocha