Replace usage of pkg_resources.iter_entry_points [2.11 version] #9013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated and to be removed soon: ``` UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81. ``` Use `importlib.metadata` instead.
wardi
reviewed
Jul 3, 2025
| for ep in entry_points(group=SYSTEM_PLUGINS_ENTRY_POINT_GROUP): # type: ignore | ||
| ep.load() | ||
| eps.append(ep.name) | ||
| except TypeError: |
There was a problem hiding this comment.
does the TypeError happen in the entry_points call? If so it would be better to not accidentally mask a TypeError from the load call. Same for the code below.
wardi
requested changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.11 version of #8992
Slightly more complex as the entry_point functions have different signatures on Python 3.9