Refactorings for Python 3.11 and 3.12 support #8357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`loader.find_module()` was deprecated and has been removed in py3.12, refactored the code following the examples on: https://docs.python.org/3.9/library/importlib.html#importing-programmatically
`datetime.datetime.fromisoformat()` got more lenient in Python 3.11, so some of the tested strings result in valid dates: https://docs.python.org/3.11/library/datetime.html#datetime.datetime.fromisoformat
|
Successfully created backport PR for |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor module loading for Python 3.12 support:
loader.find_module()was deprecated and has been removed in py3.12,refactored the code following the examples on:
https://docs.python.org/3.9/library/importlib.html#importing-programmatically
Refactor dates tests for Python 3.11 support:
datetime.datetime.fromisoformat()got more lenient in Python 3.11, sosome of the tested strings result in valid dates:
https://docs.python.org/3.11/library/datetime.html#datetime.datetime.fromisoformat
Part of getting everything green in our CKAN / Python matrix: https://github.com/ckan/ckan-python-monitor