Skip to content

[Backport dev-v2.11] Prevent exception in Datatables view when the size field is missing #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

[Backport dev-v2.11] Prevent exception in Datatables view when the size field is missing #8285

merged 2 commits into from
Jun 20, 2024

Conversation

ckanbot
Copy link

@ckanbot ckanbot commented Jun 20, 2024

This is an automated backport pull request 🏗️.

Details
Original pull request #8284 (Prevent exception in Datatables view when the size field is missing)
Original author @amercader
Target branch dev-v2.11

Please make sure that all relevant checks pass before merging it.

amercader added 2 commits June 20, 2024 13:03
@amercader @github-actions
Prevent exception in Datatables view when the size field is missing
0ae6857 
For instance when using a custom schema without this field.

Also use the `h.localise_filesize()` helper instead of the more
convoluted `h.SI_number_span(res.size)|striptags`

(cherry picked from commit 3a50fc1)
@amercader @github-actions
Add changelog
399544a 
(cherry picked from commit d154cfe)
@ckanbot ckanbot mentioned this pull request Jun 20, 2024
Merged
1 task
@wardi wardi merged commit f90a63f into dev-v2.11 Jun 20, 2024
@wardi wardi deleted the backport-8284-to-dev-v2.11 branch June 20, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckanbot @wardi @amercader