-
Notifications
You must be signed in to change notification settings - Fork 2.1k
definition list for data dictionary view #8110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7753765
to
2031711
Compare
@smotornyuk here's the change with an accordion added that I think is an general improvement. I've added the type information to the header so it's visible even when not expanded. WDYT? (and am I using columns wrong for this? adding a |
Looks good. As for By itself, It's better not to rely on this behavior, because it's specific for Bootstrap v4 and v5 an may change in future. But we are going to update styles anyway, so we can tolerate this inconvenience. The only thing that requires changes is |
Thank you @smotornyuk . Here's a fix that updates those column classes and the accordion functionality from fields that have no data dictionary labels/descriptions/extra information. Here the second field has no title/description/extra so it can't be clicked and has no arrow on the right: |
Fixes #8108
Proposed fixes:
Switch data dictionary from a table display to a definition list to allow additional information to be added for each field.
Current:
New:
New with additional information per field:
Features: