Replace usage of pkg_resources.iter_entry_points, update exception message #8992
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated and to be removed soon: ``` UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81. ``` Use `importlib.metadata` instead.
This was referenced Jun 10, 2025
|
The changes are not compatible with Python 3.9. Waiting on #8994 to update the workflows |
Not a fan of doing these but the calls are correct according to the docs https://docs.python.org/3.10/library/importlib.metadata.html#entry-points
amercader
added a commit
that referenced
this pull request
Jun 12, 2025
|
Typing errors will be fixed when #8995 is merged |
wardi
reviewed
Jun 23, 2025
wardi
reviewed
Jun 26, 2025
❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. |
|
@wardi Not sure what codecov is going on about, but this is ready to go |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dev-v2.11
git worktree add -d .worktree/backport-8992-to-dev-v2.11 origin/dev-v2.11
cd .worktree/backport-8992-to-dev-v2.11
git switch --create backport-8992-to-dev-v2.11
git cherry-pick -x e17ff328c87c3967c1f2aa2be8199ce4c44c92b9 6a1a513a13e3d89b84084ddd29926d8b83b97cf6 7c0c04b2ccc10f462b4979b50c225edd930ae1b2 beb3ba6845158fa5dd82b81a1d3eddd292fd8ae1 b81cac761585ca0860ebcb3df2b60a5e852a3fba 8d037744f0a842fd0247926804ebd5cb7bd85298 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dev-v2.10
git worktree add -d .worktree/backport-8992-to-dev-v2.10 origin/dev-v2.10
cd .worktree/backport-8992-to-dev-v2.10
git switch --create backport-8992-to-dev-v2.10
git cherry-pick -x e17ff328c87c3967c1f2aa2be8199ce4c44c92b9 6a1a513a13e3d89b84084ddd29926d8b83b97cf6 7c0c04b2ccc10f462b4979b50c225edd930ae1b2 beb3ba6845158fa5dd82b81a1d3eddd292fd8ae1 b81cac761585ca0860ebcb3df2b60a5e852a3fba 8d037744f0a842fd0247926804ebd5cb7bd85298 |
|
2.11 version is here: #9013. On 2.10 the plugins code was too different to apply the patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resourcesis deprecated and to be removed soon, replace it withimportlib.metadatainstead. :While working on that code, I never liked this exception message when trying to load an non-existent plugin:
So I updated the message: