Skip to content

[Midnight blue] Dataset/Resource page #8965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 12, 2025

Conversation

aleeexgreeen
Copy link
Contributor

Proposed fixes:

  • Added back the open data license image
  • Tweaked the dataset creation accordions to look like design and original commit in [UI revamp] Dataset create page #8503
  • Added H1s to all resource and dataset pages
  • Changed resource social from "twitter" to "X"
  • Removed references to $bgpath to remove console log error
  • Added dropdown arrow to "visibility" select in dataset form
  • Added "module-group" for dataset and resource side bar and replaced the accordions based on discussion with the designer
  • Tweaked package_wrench so the wrench is not visible to the public, similarly to the resource wrench
  • Put "What's a resource" helper in an accordion to match organization and group helpers in [Midnight blue] Organization and groups pages layout #8923
  • Uses the resources.html snippet to display resources for new datasets * This is only shown when there is a resource added and the "add another" is pressed.

Screenshots:

image
image

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

aleeexgreeen and others added 2 commits May 27, 2025 20:38
Dataset/localization and indentation fixes

Co-authored-by: Ian Ward <ian@excess.org>
@wardi
Copy link
Contributor

wardi commented May 28, 2025

Screenshot from 2025-05-28 14-26-00
There's a lot of empty space between the breadcrumbs and the main content on the page.

WDYT about putting the breadcrumbs and "Manage" / "View dataset" button on the same row?

@aleeexgreeen
Copy link
Contributor Author

WDYT about putting the breadcrumbs and "Manage" / "View dataset" button on the same row?

@wardi I changed the breadcrumb spacing and content action in #8923, do you still think it's too much whitespace?
image

@wardi
Copy link
Contributor

wardi commented May 29, 2025

I do, but, I've never been accused of being good at web design. Let's leave the whitespace as is.

@amercader
Copy link
Member

Minor thing but the org placeholder image seems broken in this branch:

Screenshot 2025-05-30 at 13-03-18 OREDP SEA Tidal Resource Shoreline 5-10Km - Dataset - CKAN

@aleeexgreeen
Copy link
Contributor Author

Okay, I've changed the helpers in the sidebars slightly to match the new design for the sidebar of the dataset and resource pages.

image

The design is new to the theme, so once this is merged, I'll apply the changes to #8923

@amercader the organization image issue is fixed in the organization PR

@amercader amercader merged commit 05203eb into ckan:master Jun 12, 2025
25 of 26 checks passed
@avdata99 avdata99 mentioned this pull request Jul 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants