Skip to content

[Midnight blue] Organization and groups pages layout #8923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 24, 2025

Conversation

aleeexgreeen
Copy link
Contributor

@aleeexgreeen aleeexgreeen commented May 3, 2025

Proposed fixes:

  • Organization and Group pages only have one H1 for each page (within main content of page).
  • Organization, Group, and Dataset search pages' H1 is in pre-primary
  • UI changes to org & group pages side bar
  • Org & group search helper information and add/edit member helper is in an accordion
  • Removes duplicate heading in organization bulk_process.html
  • Consistent bookmarks and content action across all org and group sub pages

Screenshots:

image
Mobile:
image

Organizations
Groups

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@wardi
Copy link
Contributor

wardi commented May 28, 2025

The Organizations facet is showing on the organization dataset page, and the groups facet is shown on the group dataset page, they should be hidden, right?

@amercader
Copy link
Member

Two minor comments from me:

  • I don't like the accordion in the org info heading either, they are confusing with the search filters accordions. I think sidebar boxes in [Midnight blue] Dataset/Resource page #8965 look fine if this is what you mean:

Screenshot 2025-05-30 at 12-00-18 Organizations - CKAN

  • Regarding this:

    Organization, Group, and Dataset search pages' H1 is in pre-primary

    I think they are a bit redundant , and I can't find them in the Figma designs (or it's likely that I'm looking at the wrong place in Figma). What's the rationale behind them? AFAICT they are only present in the top level Dataset/org/group pages.
    If they really need to be there perhaps we can add a bit more spacing below the header to match the one above?
    Screenshot 2025-05-30 at 11-56-03 Dataset - CKAN

Other than these, this looks good to me

@aleeexgreeen
Copy link
Contributor Author

The Figma link you sent has the heading within the main content, this is what it would look like with the current implementation
image

The change to move it to outside the main content was to make the 3 main search pages slightly different than the other pages, to kind of mark their importance.

@aleeexgreeen
Copy link
Contributor Author

I have switched the H1s to be inside the main content. Which one do you (& the community) prefer @wardi @amercader ?

Logged in users:
image

Not logged in user:
image

The H1 can go underneath the primary action like this as well, if preferred:
image

@wardi
Copy link
Contributor

wardi commented Jun 15, 2025

The H1s inside the main content does look better.

In the last example the primary action below the H1 makes more sense to me. Maybe the tabs should be below as well. The "Test Organization" tabs are displaying an aspect of the organization so it's strange for them to be above the organization title. Also the "Manage" button is most tightly related to the organization so those should be closer together.

@aleeexgreeen
Copy link
Contributor Author

I opted to move the primary action to the right side, but while talking to the designers we agreed the tabs should stay at the top of the page since it is navigation.

image
image

@aleeexgreeen
Copy link
Contributor Author

I'm now wondering since we are moving the "Add new resource" button to the top of the dataset page beside the "Manage" button, whether we should consider doing the same for the "Add dataset" button on the groups and organization pages?
image
The design would be consistent, but the designs for the org, group and dataset search pages would need to change from having a primary action to having a content action.
image
@wardi wdyt?

@wardi
Copy link
Contributor

wardi commented Jul 7, 2025

I like the idea. It puts all the buttons for making changes to things together.

@wardi wardi added this to the CKAN 2.12 milestone Jul 23, 2025
@wardi wardi merged commit 1105e38 into ckan:master Jul 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants