https://github.com/DataShades/ckanext-collection/blob/master/ckanext/collection/assets/js/htmx-init-ckan-modules.js

htmx upgrade will disappear from this PR once #8837 is merged

@mutantsan you mentioned a fix like https://github.com/DataShades/ckanext-collection/blob/master/ckanext/collection/assets/js/htmx-init-ckan-modules.js but that doesn't re-initialize elements that have already been initialized once. What's the link for that?

Hey, @wardi. This is an example of such script. After an initialization, we're adding a custom attribute on an element, marking it as initialized. If there was no extra swap with HTMX, the attribute will remain there and tell us, that we don't need to initialize the CKAN module again.

As about your PR:

1. I'd suggest hiding the Revoke tokens button, when we don't have any tokens. And a few things about how you use it:
   a. It kinda looks, like it might revoke all your token
   b. When you click it without selecting anything, just nothing happens. I don't get any response. Unlike the create button, where I know, that I have to give token a name.
   c. I'd like to see a confirmation window before deleting the token.
2. I can't say I really like placing the newly created token inside the table.
3. And when you submit an empty form, you got an extra error message just above the input, is this an indented behavior? For me, it's kinda self-explanatory, as we already add an error under the input.

While I've been thinking about the 1b, where you'd like to get some response from a server... Maybe we need to rework the notification system in CKAN a bit?

For example, use something like this - https://marcelodolza.github.io/iziToast/

Hey, @wardi. This is an example of such script. After an initialization, we're adding a custom attribute on an element, marking it as initialized. If there was no extra swap with HTMX, the attribute will remain there and tell us, that we don't need to initialize the CKAN module again.

Thank you that's perfect. I've added this here https://github.com/ckan/ckan/pull/8808/files#diff-e142270f118d5903f9f1793439f0fac16469a99cc8af699ef95bc31283583120R18-R35

As about your PR:

1. I'd suggest hiding the Revoke tokens button, when we don't have any tokens. And a few things about how you use it:
   a. It kinda looks, like it might revoke all your token
   b. When you click it without selecting anything, just nothing happens. I don't get any response. Unlike the create button, where I know, that I have to give token a name.

The revoke tokens button is now disabled until at least one token is selected.

c. I'd like to see a confirmation window before deleting the token.

I've fixed the confirm-actions module so it works with HTMX forms and added it back in.

2. I can't say I really like placing the newly created token inside the table.

This is the best approach I could think of because:

1. I want users to be able to create multiple tokens
2. I want users to be able to revoke tokens they've just created
3. When a user refreshes the page their new tokens do appear in the table so this seems like the most natural place for them

I've swapped the order so that newer tokens appear at the top right below the form (see the clip above). This way moving the focus to the new token typically doesn't have to scroll the page at all. I also think it makes more sense to see the recently created ones first.

3. And when you submit an empty form, you got an extra error message just above the input, is this an indented behavior? For me, it's kinda self-explanatory, as we already add an error under the input.

Agreed. I've removed the error summary from the form.

@wardi looks perfect now

Bumping this back to a draft because I want to add some generic HTMX error display code to ckan as part of the same PR

@amercader I've updated the error display with your feedback and used toasts based on @smotornyuk 's suggestion. Now when a standard error page is returned (e.g. via a base.abort(400, 'this was a naughty request')) users will see just the message extracted from the page:

If the message can't be found in the response we'll display the message from HTMX which includes the request URL that might be useful for users to report to the site maintainers:

@wardi this looks good, we can merge once the typing error is fixed.

I think the toasts design needs to be polished a bit but it can be done in a later PR.

I have a big monitor and it wasn't very apparent at first. Perhaps we can increase the delay before they disappear.

@aleeexgreeen just a heads up that we are now using this new UI element (just for errors coming from AJAX calls for now)

Increasing the delay is a good idea. I did notice that they stay up if you hover or tap on them which is a nice touch.