Fix language code in html lang global attribute #8698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8697 Language codes in the `<html>` global tag must follow RFC 5646 ( also known as BCP 47). Region subtags are separated with a hyphen rather than an underscore which is what we use elsewhere in the code. This just changes this particular usage as other places like the DataTables view rely on the underscore format returned by `h.lang()`
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8697
Language codes in the
<html>global tag must follow RFC 5646 ( also known as BCP 47). Region subtags are separated with a hyphen rather than an underscore which is what we use elsewhere in the code.This just changes this particular usage as other places like the DataTables view rely on the underscore format returned by
h.lang()