Skip to content

Conversation

wardi
Copy link
Contributor

@wardi wardi commented Feb 27, 2025

Fixes #8692

Proposed fixes:

datastore column comments should not be processed for sqlalchemy bind parameters

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

comment text should not be processed for sqlalchemy bind parameters
@amercader amercader self-assigned this Mar 4, 2025
@amercader amercader merged commit 5ea1fe5 into master Mar 18, 2025
9 checks passed
@amercader amercader deleted the 8692-datastore-upgrade-fix branch March 18, 2025 14:04
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
@ckanbot
Copy link

ckanbot commented Mar 18, 2025

Successfully created backport PR for dev-v2.11:

@wardi
Copy link
Contributor Author

wardi commented Mar 18, 2025

backport labels shouldn't have targeted 2.10

duttonw pushed a commit to qld-gov-au/ckan that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ckan datastore upgrade fails when comments resemble sqlalchemy bind param (eg: {"key":null})
3 participants